New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #386

Merged
merged 16 commits into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@zyzhu
Contributor

zyzhu commented Jul 5, 2018

I've made some attempts to fix the build on machine with only VS2017 and R-3.4.3 installed. I've also fixed the travis build (It's my first time trying travis. I followed similar travis settings from ProjectScaffold and FSharp.Data). All tests are passed on travis now.

  • Updated FSharp.Core to 4.2.3 (aligned with fsharp.formatting) and referenced nuget source instead of the one on machine. Target FSharp 4.4.1.0 now. I didn't attempt to go all the way to dotnet standard yet as I'm not sure whether RProvider will work or not.

Updated the following build tool chains.

  • FSharp.Formatting 3.0.0-beta11 (lots of breaking changes from FSharp.Formatting 2.x. Fixing this took most of time. But the documents generated locally look alright)
  • FSharp.Compiler.Service 22.0.3 (old compiler services had bug and documents cannot be generated on mono)
  • FSharp.Data 2.4.6
  • Math.Numerics 4.5.1
  • RProvider to 1.1.20
  • NUnit 3.8.0
  • FAKE 4.64.13

One thing that I'm not sure is I commented out the fsi files in Deedle project. I couldn't compile the library with them included. But all tests are passed. Please let me know what these files are for. @tpetricek
FSharp.Data\TextRuntime.fsi
FSharp.Data\StructuralTypes.fsi
FSharp.Data\StructuralInference.fsi
FSharp.Data\CsvRuntime.fsi
FSharp.Data\CsvFile.fsi
FSharp.Data\CsvInference.fsi

@tpetricek

This comment has been minimized.

Member

tpetricek commented Jul 6, 2018

I'll merge this now, but I opened issue #387 because I think this PR disabled documentation test - which is not crucial but would be nice to fix at some point.

@tpetricek tpetricek merged commit 33424d1 into fslaborg:master Jul 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tpetricek

This comment has been minimized.

Member

tpetricek commented Jul 6, 2018

Doh, it turns out that I still only have VS2015 on my machine and this does not build with VS2015. I guess I'll have to update before doing more work on this :(

@zyzhu

This comment has been minimized.

Contributor

zyzhu commented Jul 6, 2018

@tpetricek I’ve fixed the build with the latest commit. Tested on Vm with only VS2015 and R3.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment