Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.3 released from master instead of main #445

Closed
radeksimko opened this issue Apr 22, 2022 · 5 comments
Closed

v1.5.3 released from master instead of main #445

radeksimko opened this issue Apr 22, 2022 · 5 comments

Comments

@radeksimko
Copy link

radeksimko commented Apr 22, 2022

Describe the bug

https://github.com/fsnotify/fsnotify/releases/tag/v1.5.3 points to a commit from February on the master branch.

Expected behavior

https://github.com/fsnotify/fsnotify/releases/tag/v1.5.3 to point to the latest commit on main

Additional context

https://github.com/fsnotify/fsnotify/tags

Screenshot 2022-04-22 at 06 54 24

@mattn
Copy link
Member

mattn commented Apr 22, 2022

Ah, I tagged commit provided from pull-request which was filed before we switched to main from master.

@mythi
Copy link

mythi commented Apr 25, 2022

for github repos using dependabot, v1.5.3 gets proposed automatically which is probably not want people want so it'd nice to have this fixed

@mattn
Copy link
Member

mattn commented Apr 25, 2022

Fixed.

@radeksimko
Copy link
Author

radeksimko commented Apr 25, 2022

@mattn Would you mind cutting this as a separate 1.5.4 release/tag?

I think that all the caching layers incl. Go proxy will not appreciate force-pushed tag which was already cached and points to an existing hash. It also makes it hard for those who have already upgraded to the "previous" 1.5.3 to upgrade to the "new" 1.5.3.

This was referenced Apr 25, 2022
@shogo82148
Copy link
Member

shogo82148 commented Apr 27, 2022

I just release v1.5.4 and retracted v1.5.3.
Please get the latest version.

go get github.com/fsnotify/fsnotify@latest

And more, I updated v1.5.3 to the previous commit.
Getting v1.5.3 is now working, but you will see a warning message.

go get github.com/fsnotify/fsnotify@v1.5.3
go: warning: github.com/fsnotify/fsnotify@v1.5.3: retracted by module author: Published an incorrect branch accidentally https://github.com/fsnotify/fsnotify/issues/445
go: to switch to the latest unretracted version, run:
	go get github.com/fsnotify/fsnotify@latest

GabrielNagy added a commit to ubuntu/adsys that referenced this issue May 30, 2022
retracted by module author:

Published an incorrect branch accidentally
fsnotify/fsnotify#445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants