windows: protect access to isClosed with mutex #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isClosed may be read and modified concurrently if the Windows Watcher is closed at the same time as a new entry being added. This change protects isClosed to prevent race conditions. The order of fields for the Windows Watcher have been rearranged to group fields protected by the mutex together.
arp242
approved these changes
Jul 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isClosed may be read and modified concurrently on Windows if the Watcher is closed at the same time as a new entry being added. This change protects isClosed to prevent race conditions.
The order of fields for the Windows Watcher have been rearranged to group fields protected by the mutex together to make it easier for reviewers to understand at a glance which fields are expected to be accessed through the mutex.