Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go vet warnings: call to (*T).Fatalf from a non-test goroutine #416

Merged
merged 1 commit into from Jan 17, 2022
Merged

fix go vet warnings: call to (*T).Fatalf from a non-test goroutine #416

merged 1 commit into from Jan 17, 2022

Conversation

shogo82148
Copy link
Member

@shogo82148 shogo82148 commented Jan 15, 2022

What does this pull request do?

fixes go vet warnings:

./inotify_poller_test.go:182:5: call to (*T).Fatalf from a non-test goroutine
./inotify_test.go:341:4: call to (*T).Fatalf from a non-test goroutine
./integration_test.go:80:4: call to (*T).Fatalf from a non-test goroutine
./integration_test.go:843:4: call to (*T).Fatalf from a non-test goroutine

closes #412

Where should the reviewer start?

Read #412 and #414 to understand the problem and make sure testing.T is correctly used.

How should this be manually tested?

Run go vet locally.

Copy link
Contributor

@nshalman nshalman left a comment

This looks good to me, go vet is happy on my illumos machine in my branch and the tests still pass. Thank you!

@mattn mattn merged commit 73c3b57 into fsnotify:main Jan 17, 2022
1 check passed
@mattn
Copy link
Member

mattn commented Jan 17, 2022

Thanks

ianyh pushed a commit to PreVeil/fsnotify that referenced this pull request Jan 19, 2022
* introduce GitHub Actions

* Add lint+vet+old versions to GitHub Action

* Remove Travis CI and references

* Drop support/testing for Go 1.11 and earlier (fsnotify#381)

* Update x/sys to latest (fsnotify#379)

* add //go:build lines + add 1.17.0-rc2 to test matrix (fsnotify#377)

* Update test matrix for go 1.17 stable release (fsnotify#385)

* Add AddRaw to not follow symlinks + Fix link folloing on Windows (fsnotify#289)

* v1.5.0 preparation (fsnotify#380)

* revise pull request template

* Revert "Add AddRaw to not follow symlinks + Fix link folloing on Windows (fsnotify#289)"

This reverts commit e2e9517.

* prepare 1.5.1, retract 1.5.0

* Removed dead link

* Update issue templates (fsnotify#410)

* Update issue templates

* remove old issue template

* Test on Go 1.18 and two most recent versions (fsnotify#411)

* Test on Go 1.18 and two most recent versions

* on push

* ci

* update readme

* revise contributing

* maintainers wanted

* Final Notice: Maintainers Wanted

* fix go vet warnings: call to (*T).Fatalf from a non-test goroutine (fsnotify#416)

* made the changes related to recursive directory check

* made changes in window.go for buffer size

* DA-992: Pair windows' delete + create event to generate a rename event (#1)

* made the changes related to recursive directory check

* made changes in window.go for buffer size

* added the oldname attribute

* old name added to rename event, one event is generated for rename

* added oldname in printing rename events

* tests for checking  the oldName attr for rename added

* create fsnotify event added

* input to create event changed

* create fsnotify event function modified

* ID added

* logs added

* added create fsnotify event in inotify

* logs added

* prints added

* reviews

* reviews addressed

* Hangkun/da 992/window rename event (#2)

* Let's begin

* Add getpath

* Init test workflow

* 1.40.0 exits?

* Linter fix

* asdf

* 100

Co-authored-by: hu13 <hangkun@preveil.com>

* Clean up unused

* Badge

Co-authored-by: Hangkun Ung <hangkun.ung@gmail.com>
Co-authored-by: hu13 <hangkun@preveil.com>

* Rebase upstream fixes

* Rename bundle only works on windows

* Update CI golang

Co-authored-by: Ichinose Shogo <shogo82148@gmail.com>
Co-authored-by: Oliver Bristow <evilumbrella+github@gmail.com>
Co-authored-by: Nahum Shalman <nahamu@gmail.com>
Co-authored-by: Nathan Youngman <4566+nathany@users.noreply.github.com>
Co-authored-by: Loïc Vernet <vernet.loic@gmail.com>
Co-authored-by: Nathan Youngman <git@nathany.com>
Co-authored-by: paris <pariya.b@gmail.com>
Co-authored-by: hu13 <hangkun@preveil.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go vet: call to (*T).Fatalf from a non-test goroutine
3 participants