Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change docker port forwarding based on $INPUT_PORT #60

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

mulac
Copy link
Contributor

@mulac mulac commented Aug 13, 2023

When setting the port in the action parameters the docker container still only listens on the default port.

This change adds a test to ensure the server is accessible when different ports are set and changes the port docker forwards based on the port parameter.

Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fsouza fsouza merged commit f15a0fa into fsouza:main Aug 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants