Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttachToContainer - Content-Type error with 1.10 #455

Closed
beetree opened this issue Feb 1, 2016 · 11 comments
Closed

AttachToContainer - Content-Type error with 1.10 #455

beetree opened this issue Feb 1, 2016 · 11 comments
Labels

Comments

@beetree
Copy link

beetree commented Feb 1, 2016

I have a setup using .AttachToContainer. After upgrading to Docker 1.10-rc2 I'm getting an error Content-Type specified (plain/text) must be 'application/json'.

Why am I getting this?

Any help would be great!

/beetree

@beetree
Copy link
Author

beetree commented Feb 1, 2016

Row 590 in this file: https://github.com/fsouza/go-dockerclient/blob/b3de6cfc437eb5bb97b5b28ed827bcdbd7860e22/client.go

I think that should be changed to application/json.

@beetree
Copy link
Author

beetree commented Feb 1, 2016

Confirmed. Changing line 590 fixes the problem. If there's a 1.10 branch I'd be happy to submit the fix myself...?

@fsouza
Copy link
Owner

fsouza commented Feb 2, 2016

@beetree do you know if using application/json in previous versions of the API work? If so, you can send the change right away. Otherwise we should provide a solution for supporting both plain/text and application/json.

@beetree
Copy link
Author

beetree commented Feb 5, 2016

No sorry, haven't tested that.

@fsouza
Copy link
Owner

fsouza commented Feb 5, 2016

No problem, I'm on it right now! :-)

@fsouza fsouza closed this as completed in 0099401 Feb 5, 2016
@fsouza
Copy link
Owner

fsouza commented Feb 5, 2016

@beetree just pushed a fix for this issue, can you give it a try? Thanks!

@fsouza fsouza added the bug label Feb 5, 2016
@beetree
Copy link
Author

beetree commented Feb 6, 2016

Confirmed, working.

@gopinatht
Copy link

@beetree @fsouza What version of docker has the fix been pushed to? How can I access it?

@beetree
Copy link
Author

beetree commented Feb 9, 2016

Of docker? The current dockerclient should work with both docker 1.9.1 and
1.10. The old version of dockerclient was not working with docker 1.10.

On Tue, Feb 9, 2016 at 9:59 AM, gopinatht notifications@github.com wrote:

@beetree https://github.com/beetree @fsouza https://github.com/fsouza
What version of docker has the fix been pushed to? How can I access it?


Reply to this email directly or view it on GitHub
#455 (comment)
.

@gopinatht
Copy link

@beetree: Aha, my mistake. I am seeing this error coming from the kubectl world and am not completely familiar with the go dockerclient. So I mistakenly thought this was a fix went directly into the docker. Apologies and thanks for the clarification.

@fsouza
Copy link
Owner

fsouza commented Feb 9, 2016

@gopinatht it should be fixed in the next version of Kubernetes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants