Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Go to Metadata #906

Merged
merged 6 commits into from Dec 29, 2014

Conversation

Projects
None yet
2 participants
@dungpa
Copy link
Member

commented Dec 26, 2014

This PR did multiple tweaks.

The most important change is to try to find locations of matching symbols when going to metadata. We get all symbols of the generated signature and match with the original symbol by full names and symbol kinds.

Close #683.

@dungpa dungpa changed the title Misc Improve Go to Metadata Dec 26, 2014

@vasily-kirichenko

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2014

Does not work for Seq.map.

@vasily-kirichenko

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2014

Does not set cursor at AutoOpenAttribute when F12 on [<AutoOpen>].

@vasily-kirichenko

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2014

Does not set cursor at Microsoft.FSharp.Reflection.FSharpValue.GetUnionFields.

@dungpa

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2014

Fixed.

The heuristics will not be complete, but I think this is still much better than not setting cursor positions. I will try to enhance these heuristics over time.

vasily-kirichenko added a commit that referenced this pull request Dec 29, 2014

Merge pull request #906 from dungpa/misc
Improve Go to Metadata

@vasily-kirichenko vasily-kirichenko merged commit f52724b into fsprojects:master Dec 29, 2014

1 check passed

continuous-integration/appveyor AppVeyor build succeeded
Details

@dungpa dungpa deleted the dungpa:misc branch Dec 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.