This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove the breaking change I would have to use nullable types instead of option, but this is not best idea in F# I think.
I'm not familiar with spliting the package out of repository, so I would try first the second option. It will take probably few days.
Sorry for such long break. I want to make a new module SqlPackage and put there my changes, leaving old DacPac module without change. @matthid would be better to revert these commits and make change here in this PR, or maybe create new branch and new PR?
Sorry for the late review, I asked two small questions and I think one small thing is missing. You added a new documentation file (help/markdown/sql-sqlpackage.md) which is awesome, but for someone to find it you should add links somewhere (probably in the menu in help/templates/template.cshtml)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.