Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ProvidedTypes form FSharp.Data #48

Conversation

vasily-kirichenko
Copy link
Contributor

fix memory leak caused by hiding Disposable member implemented in ProvidedTypes.

@forki @dungpa I'm not sure it's totally OK that I pick ProvidedTypes.fs/fsi from FSharp.Data repository. Where can I get the latest vanilla ProvidedTypes?

fix memory leak caused by hiding Disposable member implemented in ProvidedTypes
@dsyme
Copy link
Contributor

dsyme commented Dec 12, 2014

In theory the latest is the one in the F# Type Provider Starter Pack.

@sergey-tihon
Copy link
Member

As I know the latest version is it FSharp.TypeProviders.StarterPack. Am I right @mavnn?

@vasily-kirichenko Now you have a unique possibility to reference latest version using Paket.
Example is here - https://github.com/mavnn/Inrush/blob/master/paket.dependencies#L13

@dsyme
Copy link
Contributor

dsyme commented Dec 12, 2014

It would be great to get the Travis build fixed - any idea what this error is? https://travis-ci.org/fsprojects/FSharp.Configuration/builds/43840015#L467

@dungpa
Copy link

dungpa commented Dec 12, 2014

I think FSharp.TypeProviders.StarterPack has the latest bits. @ReedCopsey did a PR fsprojects/FSharp.TypeProviders.SDK#23 to fix potential memory leaks there a few months ago.

@sergey-tihon
Copy link
Member

I think that we should mention in README.md of FSharp.TypeProviders.StarterPack
That is it official home for ProvidedTypes and repo contains latest version of files.

Your thoughts? @dsyme @mavnn @ReedCopsey @dungpa

@dsyme
Copy link
Contributor

dsyme commented Dec 12, 2014

Yes, please do that. See also this discussion: fsprojects-archive/zzarchive-VisualFSharpPowerTools#474 (comment)

@mavnn
Copy link

mavnn commented Dec 12, 2014

Sounds good. I'm feeling somewhat ill at the moment: if anyone gets around
to sending a pull request I'll try and make sure I merge it.
On 12 Dec 2014 14:51, "Sergey Tihon" notifications@github.com wrote:

I think that we should mention in README.md of
FSharp.TypeProviders.StarterPack
That is it official home for ProvidedTypes.fs and repo contains latest
version of files.

Your thoughts? @dsyme https://github.com/dsyme @mavnn
https://github.com/mavnn @ReedCopsey https://github.com/ReedCopsey
@dungpa https://github.com/dungpa


Reply to this email directly or view it on GitHub
#48 (comment)
.

vasily-kirichenko added a commit that referenced this pull request Dec 12, 2014
…x-memory-leak

update ProvidedTypes form FSharp.Data
@vasily-kirichenko vasily-kirichenko merged commit f81cb93 into fsprojects:master Dec 12, 2014
@vasily-kirichenko
Copy link
Contributor Author

Published in NuGet package 0.4.7

vasily-kirichenko pushed a commit to vasily-kirichenko/FSharp.Configuration that referenced this pull request May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants