From f1c9af3041d53aab434a6be0c72ddbb95df0420d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 15 Apr 2026 01:22:14 +0000 Subject: [PATCH 1/2] perf: use while! in tryTail inner loop, removing redundant mutable go flag Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- release-notes.txt | 1 + src/FSharp.Control.TaskSeq/TaskSeqInternal.fs | 8 +------- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/release-notes.txt b/release-notes.txt index cfe2d7d..f4155e7 100644 --- a/release-notes.txt +++ b/release-notes.txt @@ -8,6 +8,7 @@ Release notes: - perf: TaskSeq.chunkBy and chunkByAsync reuse the ResizeArray buffer between chunks, reducing allocations on sequences with many chunk boundaries - fixes: TaskSeq.insertAt, insertManyAt, removeAt, removeManyAt, updateAt now raise ArgumentNullException (not NullReferenceException) when given a null source; insertManyAt also validates the values argument - refactor: simplify lengthBy and lengthBeforeMax to use while! and remove the redundant mutable 'go' and initial MoveNextAsync + - refactor: simplify tryTail inner loop to use while!, removing redundant mutable 'go' flag and initial MoveNextAsync - adds TaskSeq.distinctUntilChangedWith and TaskSeq.distinctUntilChangedWithAsync, #345 - adds TaskSeq.withCancellation, #167 - adds TaskSeq.replicateInfinite, replicateInfiniteAsync, replicateUntilNoneAsync, #345 diff --git a/src/FSharp.Control.TaskSeq/TaskSeqInternal.fs b/src/FSharp.Control.TaskSeq/TaskSeqInternal.fs index b6f77a3..ed8e095 100644 --- a/src/FSharp.Control.TaskSeq/TaskSeqInternal.fs +++ b/src/FSharp.Control.TaskSeq/TaskSeqInternal.fs @@ -845,14 +845,8 @@ module internal TaskSeqInternal = | true -> return taskSeq { - let mutable go = true - let! step = e.MoveNextAsync() - go <- step - - while go do + while! e.MoveNextAsync() do yield e.Current - let! step = e.MoveNextAsync() - go <- step } |> Some } From a55407d1a9e88d2f1ae20737e7f103e081bd64f9 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Wed, 15 Apr 2026 01:22:16 +0000 Subject: [PATCH 2/2] ci: trigger checks