net461 and netstandard2.0 with working evaluation #480

thinkbeforecoding · 2018-10-14T14:09:03Z

This version prepares FSharp.Literate to work on netstandard2.0 with evaluation to be used from netcoreapp projects.
The net461 version is still built with command line tools

wallymathieu · 2018-10-14T15:16:26Z

Cool! I hope it goes well with the PR!

thinkbeforecoding · 2018-10-14T15:23:32Z

I have a problem with travis:

The current .NET SDK does not support targeting .NET Core 2.1. Either target .NET Core 2.0 or lower, or use a version of the .NET SDK that supports .NET Core 2.1.

Even if the .travis.yml specifies dotnet : 2.1.4

thinkbeforecoding · 2018-10-14T15:24:59Z

An appveyor is failing with an error that I managed to fix local by removing paket-files\paket.restore.cached and running paket restore again…
But there is probably a better way to not get this error.

matthid · 2018-10-14T15:27:54Z

An appveyor is failing with an error that I managed to fix local by removing paket-files\paket.restore.cached and running paket restore again…
But there is probably a better way to not get this error.

Add that file to gitignore and do not commit it.

Even if the .travis.yml specifies dotnet : 2.1.4

Try with latest 2.1.403 or something like that. If that doesn't work I'd assume something in the build still uses an older version.

thinkbeforecoding · 2018-10-14T15:30:01Z

The directory paket-file is already in .gitignore, is appveyor working on a clean directory when launching build, or does it live the directory as is between builds ?

matthid · 2018-10-14T15:30:59Z

appveyor should use a new machine every time (so it should be clean)

thinkbeforecoding · 2018-10-14T15:57:58Z

I'm making new attempts 👍

thinkbeforecoding · 2018-10-14T16:12:00Z

Now it's complaining about net461.
The build is working fine on windows, but on mono I get:

The reference assemblies for framework ".NETFramework,Version=v4.6.1" were not found. To resolve this, install the SDK or Targeting Pack for this framework version or retarget your application to a version of the framework for which you have the SDK or Targeting Pack installed. Note that assemblies will be resolved from the Global Assembly Cache (GAC) and will be used in place of reference assemblies. Therefore your assembly may not be correctly targeted for the framework you intend.

wallymathieu · 2018-10-14T16:13:59Z

Sometimes I've had some success with using what has been done in the type providers: Working on dotnet core on Mac OS X part 2

matthid · 2018-10-14T16:23:23Z

@thinkbeforecoding You might want to add the reference assembly nuget package nuget RoslynTools.ReferenceAssemblies which can be found in the feed source https://dotnet.myget.org/F/roslyn-tools/api/v3/index.json I have already added that for similar reasons to other repositories (like FAKE).

For this to work you need to edit/add a directory.props file: https://github.com/fsharp/FAKE/blob/694f616c97fa242162cfd36db905d7df3156018f/src/Directory.Build.props#L3

thinkbeforecoding · 2018-10-14T16:45:23Z

Trying this.

thinkbeforecoding · 2018-10-14T16:55:00Z

paket fails while trying to load roslyntools… any idea ?

matthid · 2018-10-14T16:55:48Z

@thinkbeforecoding did you add the source? It is sadly not available on official nuget

thinkbeforecoding · 2018-10-14T16:59:10Z

yes I added the source and paket install is working..
But paket restore takes ages and fails.

thinkbeforecoding · 2018-10-14T17:56:11Z

@matthid added the reference assemblies and the Directory.Build.props and it's still failing with the same error.

thinkbeforecoding · 2018-10-14T18:05:29Z

I think I had the relative path wrong. new try..

thinkbeforecoding · 2018-10-14T18:22:58Z

There is some progress, now I have a problem with app.config files in tests.

thinkbeforecoding · 2018-10-15T06:34:29Z

This error also occurs only in mono. I managed to reproduce it using WSL bash for windows, but still don't know why this happens .

thinkbeforecoding · 2018-10-15T07:02:55Z

The build passed on appveyor, but I could not find testresult.xml due to the fact that it's now using dotnet test and not nunit console runner.
have to see what I do with this...

thinkbeforecoding · 2018-10-15T09:06:26Z

I have a problem reproducing the build locally because from paris downloading oslynTools.ReferenceAssemblies takes 7min and timeouting 😢

wallymathieu · 2018-10-15T17:55:27Z

Do you still need to keep app config around with the new style format?

thinkbeforecoding · 2018-10-15T18:36:35Z

Yes for the test project running in net461, they are needed for binding redirects.

When removed, a resolution of an FSharp.Core 4.1.0.0 is failing.

thinkbeforecoding · 2018-10-15T19:25:33Z

@wallymathieu the appveyor build is queued but doesn't seem to start...

wallymathieu · 2018-10-15T19:37:16Z

It will probably queue up a new build once it gets available. I can imagine that fsprojects use quite a lot of appveyor resources.

thinkbeforecoding · 2018-10-15T19:38:31Z

It has been rather quick today, but there are probably changes on other repos as well...

matthid

Some initial comments

FSharp.Formatting.TestHelpers/TestHelpers.fs

nuget/FSharp.Formatting.nuspec

tests/FSharp.MetadataFormat.Tests/files/crefLib/crefLib2.fsproj

...-files/matthid/Yaaf.FSharp.Scripting/src/source/Yaaf.FSharp.Scripting/YaafFSharpScripting.fs

thinkbeforecoding · 2018-10-15T20:57:32Z

The build finally passed on appveyor

thinkbeforecoding · 2018-10-16T14:45:35Z

Anything more ?

wallymathieu

Looks good 👍

wallymathieu · 2018-10-16T14:48:09Z

I'll wait on @matthid since this is such a big PR.

thinkbeforecoding · 2018-10-18T17:08:12Z

@matthid when do you think you'll have time for the review ? 😄 I can help if needed..

matthid

Does this update the "publishing" logic in the fake script to push thr the new package?
Is the new package sent to the appveyor feed?

appveyor.yml

matthid · 2018-10-18T19:13:09Z

build.fsx

                Arguments = sprintf "%s --fsiargs -d:FAKE %s \"%s\"" args fsiargs script
                WorkingDirectory = workingDirectory
            }
            |> Process.withFramework
-            |> Process.setEnvironmentVariable "MSBuild" MSBuild.msBuildExe
+            // |> Process.setEnvironmentVariable "MSBuild" MSBuild.msBuildExe


So we can remove this?

Yes dotnet is already doing it properly

matthid · 2018-10-18T19:14:16Z

build.fsx

@@ -537,42 +536,42 @@ Target.create"CreateTag" (fun _ ->
    Git.Branches.pushTag "" "origin" release.NugetVersion
 )

-Target.create"Release" Target.DoNothing
+Target.create"Release" ignore


Maybe we can add a space after create :)

thinkbeforecoding · 2018-10-18T19:57:21Z

Done 👍

matthid · 2018-10-18T20:07:21Z

Overall looks good, but what about the publishing of the new nuget? did you add that code or did I just miss it?

thinkbeforecoding · 2018-10-18T20:16:37Z

I've not seen where it's done :grin

thinkbeforecoding · 2018-10-18T20:22:21Z

The nuget is created in the folder, but I've not seen where it's pushed to nuget.org ..

thinkbeforecoding · 2018-10-18T20:23:51Z

Ah ! Actually the nuget/publish.cmd published all the bin/*.nupkg so it's good 👍

build.fsx

matthid

Lets see what happens, thanks a lot!

thinkbeforecoding · 2018-10-19T11:54:42Z

great 😄

thinkbeforecoding · 2018-10-22T20:05:04Z

Thx !
Where are the nuget published ?

wallymathieu · 2018-10-22T20:14:07Z

See
https://github.com/fsprojects/ProjectScaffold/blob/9777434f22bdc12a133230559d9e00bc33c785ed/paket.dependencies#L15-L17
i.e.:
https://ci.appveyor.com/nuget/fsharp-formatting

thinkbeforecoding · 2018-10-22T20:18:16Z

Ok 👍🏻 👍🏻

thinkbeforecoding added 4 commits October 14, 2018 16:05

net461 and netstandard2.0 with working evaluation

7353943

Remove dead code

c8b06f7

FSharp.Literate Nuget compilation

8608cf6

Remove invalid target

0ecc37d

Use dotnet 2.1.403

8c4eda7

thinkbeforecoding added 2 commits October 14, 2018 17:39

Fix paket lock

272d05c

Fix build

385af89

Make build work on mono

cb85bac

Fix relative file path for reference assemblies

d71fdfa

wallymathieu mentioned this pull request Oct 14, 2018

nuget RoslynTools.ReferenceAssemblies wallymathieu/assertfail#17

Closed

thinkbeforecoding added 2 commits October 15, 2018 20:58

Fix doc generation

a8efe45

Remove paket.template files

61be6a1

matthid reviewed Oct 15, 2018

View reviewed changes

FSharp.Formatting.TestHelpers/TestHelpers.fs Outdated Show resolved Hide resolved

nuget/FSharp.Formatting.nuspec Show resolved Hide resolved

tests/FSharp.MetadataFormat.Tests/files/crefLib/crefLib2.fsproj Outdated Show resolved Hide resolved

Remove useless project property

145a342

thinkbeforecoding commented Oct 15, 2018

View reviewed changes

...-files/matthid/Yaaf.FSharp.Scripting/src/source/Yaaf.FSharp.Scripting/YaafFSharpScripting.fs Show resolved Hide resolved

wallymathieu approved these changes Oct 16, 2018

View reviewed changes

matthid reviewed Oct 18, 2018

View reviewed changes

Prettify build.fsx

7d59055

thinkbeforecoding commented Oct 19, 2018

View reviewed changes

build.fsx Show resolved Hide resolved

matthid approved these changes Oct 19, 2018

View reviewed changes

matthid merged commit d8be726 into fsprojects:master Oct 22, 2018

matthid mentioned this pull request Apr 10, 2019

Update docs for v3.0 #490

Closed

net461 and netstandard2.0 with working evaluation #480

net461 and netstandard2.0 with working evaluation #480

Conversation

thinkbeforecoding commented Oct 14, 2018

wallymathieu commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

matthid commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

matthid commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

wallymathieu commented Oct 14, 2018

matthid commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

matthid commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

thinkbeforecoding commented Oct 14, 2018

thinkbeforecoding commented Oct 15, 2018

thinkbeforecoding commented Oct 15, 2018

thinkbeforecoding commented Oct 15, 2018

wallymathieu commented Oct 15, 2018

thinkbeforecoding commented Oct 15, 2018

thinkbeforecoding commented Oct 15, 2018

wallymathieu commented Oct 15, 2018

thinkbeforecoding commented Oct 15, 2018

matthid left a comment

Choose a reason for hiding this comment

thinkbeforecoding commented Oct 15, 2018

thinkbeforecoding commented Oct 16, 2018

wallymathieu left a comment

Choose a reason for hiding this comment

wallymathieu commented Oct 16, 2018

thinkbeforecoding commented Oct 18, 2018

matthid left a comment

Choose a reason for hiding this comment

matthid Oct 18, 2018

Choose a reason for hiding this comment

thinkbeforecoding Oct 18, 2018

Choose a reason for hiding this comment

matthid Oct 18, 2018

Choose a reason for hiding this comment

thinkbeforecoding Oct 18, 2018

Choose a reason for hiding this comment

thinkbeforecoding commented Oct 18, 2018

matthid commented Oct 18, 2018

thinkbeforecoding commented Oct 18, 2018

thinkbeforecoding commented Oct 18, 2018

thinkbeforecoding commented Oct 18, 2018

matthid left a comment

Choose a reason for hiding this comment

thinkbeforecoding commented Oct 19, 2018

thinkbeforecoding commented Oct 22, 2018

wallymathieu commented Oct 22, 2018 • edited

thinkbeforecoding commented Oct 22, 2018

wallymathieu commented Oct 22, 2018 •

edited