Maximize reach wrt FSharp.Core and netcoreapp versions re #6#9
Conversation
| <PropertyGroup> | ||
| <Version>1.0.0</Version> | ||
| <PackageVersion>1.0.0-beta-005</PackageVersion> | ||
| <PackageVersion>1.0.0-beta-006</PackageVersion> |
There was a problem hiding this comment.
The build script checks wether the version here and in RELEASE_NOTES are out-of-sync to to know when it should push a new release, so you don't need to update this manually :) But I can revert just this line now.
There was a problem hiding this comment.
Ah, makes sense (in https://github.com/jet/jet.jsonnet.converters et al, I use MinVer, which works well wrt inferring a suitable version, but having it tie in with release notes is more important than that).
Feel free to ping if you want me to expand on this (to be clear though: it seems the script and process is already better as-is and if it aligns with processes in sister projects it would be crazy to foist the dependency for something which will hopefully go into maintenance mode very soon!)
Thanks for the speedy merge!
I work on a project that supports
"FSharp.Core" Version="3.1.2.5"in itsnet461variant and makes use of this in samples; relaxing the constraints as this PR does means I can compile those without warnings. I have a similar need/desire to include this in adotnet newtemplate and having maximal reach is critical in that context.netcoreapp2.1in order to verify current LTS version works correctlynet461multitargeting to tests - I'm fine with this being removed or changed tonet45if it proves problematic; IMEnet461targeting is commonly with default SDK/VS installsFSharp.Coreversion requirement fornet45toVersion="3.1.2.5"FSharp.Coreversion requirement fornetstandard2.0toVersion="4.3.4"(was4.1.17) - happy to remove this change as TBH I'm not sure how enricosada landed on this