Run tests in parallel #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables running tests in parallel by adding NUnit parallelization attributes, updating test project files, and aligning module namespaces.
- Add assembly-level
Parallelizableand lifecycle attributes via newAttributes.fsin test projects - Apply
[<SingleThreaded>]to fixtures that aren’t thread-safe - Update module namespaces and import
FSharpLint.Core.Testsin many test files
Reviewed Changes
Copilot reviewed 90 out of 90 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/FSharpLint.FunctionalTest/Attributes.fs | New assembly attribute for parallel fixture execution |
| tests/FSharpLint.FunctionalTest/TestApi.fs | Renamed test method to reflect parallel config change |
| tests/FSharpLint.Core.Tests/Attributes.fs | New assembly-level parallel and lifecycle attributes |
| CHANGELOG.md | Documented the “Run tests in parallel” feature |
Comments suppressed due to low confidence (1)
tests/FSharpLint.FunctionalTest/TestApi.fs:90
- The test name replaces the actual file extension
.jsonwith_json, which could confuse readers. Consider restoring the original descriptive name (e.g.,...load fsharplint.json) to accurately reflect the file under test.
member _.``Lint project with default config tries to load fsharplint_json``() =
xperiandri
force-pushed
the
parallel-tests
branch
from
c7cf6f9 to
dcff179
Compare
xperiandri
force-pushed
the
tests-namespaces-fix
branch
from
e985162 to
5b8ddba
Compare
xperiandri
force-pushed
the
parallel-tests
branch
2 times, most recently
from
a19d754 to
5ff16c1
Compare
xperiandri
force-pushed
the
parallel-tests
branch
from
5ff16c1 to
18547b9
Compare
xperiandri
added a commit
that referenced
this pull request
Jul 11, 2025
## [0.25.0] - 2025-07-11 - Migrate from `Paket` to `Directory.Packages.props` #722 [@xperiandri] - Migrate to .NET `9.0.201` and FCS `43.9.201` #722 [@xperiandri] - Write test logs to test context output #722 [@xperiandri] - Use string interpolation instead of `+` concatenation #724 [@xperiandri] - Run tests in parallel #728 [@xperiandri] - Remove `NoPartialFunctions` compiler workaround (#698) [@webwarrior-ws] - Add `SLNX` and `SLNF` format support and migrate to SLNX solution #723 [@xperiandri] Remove `Ionide.ProjInfo.Sln` NuGet package dependency - Remove `Newtonsoft.Json` NuGet dependency #725 [@xperiandri] - Add missing rule checks for FL0079-FL0081 #713 [@BennieCopeland] - Modify `.gitignore` to the Visual Studio standard one #735 [@xperiandri] - Add basic Copilot instructions and GitHub MCP #726 [@xperiandri] - Migrate `Fornax` to `0.16.0-beta002` and `FSharp.Formatting` to `20.0.1` #736 [@xperiandri, @Numpsy] - Update the build instructions to use `dotnet fsi` instead of `fake-cli` #734 [@Numpsy]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.