diff --git a/src/FSharpLint.Core/Rules/Conventions/Naming/ParameterNames.fs b/src/FSharpLint.Core/Rules/Conventions/Naming/ParameterNames.fs index 81c22e27e..e42eebb81 100644 --- a/src/FSharpLint.Core/Rules/Conventions/Naming/ParameterNames.fs +++ b/src/FSharpLint.Core/Rules/Conventions/Naming/ParameterNames.fs @@ -41,7 +41,7 @@ let private getIdentifiers (args:AstNodeRuleParams) = | AstNode.Binding(SynBinding(access, _, _, _, attributes, _, valData, pattern, _, _, _, _, _)) -> if not (isLiteral attributes) then match identifierTypeFromValData valData with - | Value | Function -> + | Function -> let accessControlLevel = getAccessControlLevel args.SyntaxArray args.NodeIndex getPatternIdents accessControlLevel (getValueOrFunctionIdents args.CheckInfo) true pattern | Member | Property -> diff --git a/tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/ParameterNames.fs b/tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/ParameterNames.fs index 19adee889..9e0030781 100644 --- a/tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/ParameterNames.fs +++ b/tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/ParameterNames.fs @@ -78,13 +78,13 @@ let result = extractInt singleCaseDU let source = """ module Program -let __foo_bar = 0 +let baz __foo_bar = 0 """ let expected = """ module Program -let __foobar = 0 +let baz __foobar = 0 """ this.Parse source @@ -114,3 +114,14 @@ let foo ((x, y) as bar_coord) = bar_coord """ Assert.IsTrue this.ErrorsExist + + [] + member this.``Module members should not cause errors as they are not parameters``() = + this.Parse """ +module BitLaunch = + module Regions = + let Bucharest = "Bucharest" + let Amsterdam someArg = "Amsterdam" +""" + + Assert.IsFalse this.ErrorsExist