Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for implicit converters when using Shell #430

Merged
merged 2 commits into from May 31, 2019

Conversation

@TimLariviere
Copy link
Member

commented May 30, 2019

Shell heavily relies on implicit operators to convert between the numerous types required to make a good hierarchy.

This PR adds some of them.

I will surely make other PRs when I encounter other cases

@SergejDK

This comment has been minimized.

Copy link
Collaborator

commented May 30, 2019

@TimLariviere
I think for the Tab-class and TabBar there should be implicit conversion, too. Normally they include ShellContent. They came in 4.0.

@TimLariviere

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

From what I saw, Tab and TabBar use the implicit conversion of ShellContent.
They don't have operators on their own.

@SergejDK

This comment has been minimized.

Copy link
Collaborator

commented May 30, 2019

You are right! Just checked it...
Well then I think it should be easier to write shell code now.

@TimLariviere TimLariviere merged commit 32f1db6 into fsprojects:master May 31, 2019
5 checks passed
5 checks passed
PR Build Build #20190530.3 succeeded
Details
PR Build (Windows) Windows succeeded
Details
PR Build (macOS) macOS succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@TimLariviere TimLariviere deleted the TimLariviere:fix-shell-v2 branch May 31, 2019
@TimLariviere TimLariviere referenced this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.