Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Missing transitive dependencies after paket update #1190
This can also be reproduced by taking an existing project with current xunit references and then running a
The relevant diff after performing an update in one of my own projects:
--- i/paket.lock +++ w/paket.lock @@ -134,7 +134,7 @@ NUGET xunit (2.1.0) xunit.assert (2.1.0) xunit.core (2.1.0) - xunit.abstractions (2.0.0) - framework: dnx451, dnxcore50, monoandroid, monotouch, xamarinios, winv4.5, wpv8.0, >= net45 + xunit.abstractions (2.0.0) - framework: dnxcore50 xunit.assert (2.1.0) System.Collections (>= 4.0.0) - framework: dnxcore50 System.Diagnostics.Debug (>= 4.0.0) - framework: dnxcore50
I've determined that the issue was introduced in 2.19.0. The issue was not present in 2.18.0. Likely PR (unconfirmed) was #1174.
Just tried the paket update repro and that now doesn't cause a problem. It does change the dependency slightly, but only by a slight expansion of the supported frameworks. A quick glance at xunit and the dependency tree makes me think it's right, which means that if anything I'm guessing this is slightly more correct than before! For the case we discovered this on, it is certainly no longer broken :)