New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing transitive dependencies after paket update #1190

Closed
neoeinstein opened this Issue Nov 4, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@neoeinstein

neoeinstein commented Nov 4, 2015

Reproduction case:

  1. Create a new project targeting .NET 4.5.
  2. Run paket.exe add nuget xunit project myproject.tests
  3. Note that xunit.abstractions is not in the list of references

This can also be reproduced by taking an existing project with current xunit references and then running a paket update.

The relevant diff after performing an update in one of my own projects:

--- i/paket.lock
+++ w/paket.lock
@@ -134,7 +134,7 @@ NUGET
     xunit (2.1.0)
       xunit.assert (2.1.0)
       xunit.core (2.1.0)
-    xunit.abstractions (2.0.0) - framework: dnx451, dnxcore50, monoandroid, monotouch, xamarinios, winv4.5, wpv8.0, >= net45
+    xunit.abstractions (2.0.0) - framework: dnxcore50
     xunit.assert (2.1.0)
       System.Collections (>= 4.0.0) - framework: dnxcore50
       System.Diagnostics.Debug (>= 4.0.0) - framework: dnxcore50

I've determined that the issue was introduced in 2.19.0. The issue was not present in 2.18.0. Likely PR (unconfirmed) was #1174.

@neoeinstein

This comment has been minimized.

Show comment
Hide comment

neoeinstein commented Nov 4, 2015

cc: @kolektiv

@forki

This comment has been minimized.

Show comment
Hide comment
@forki
Member

forki commented Nov 4, 2015

@forki forki added the bug label Nov 4, 2015

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 4, 2015

Member

I can reproduce and the error and I understand the issue. hope to provide a fix soon.

Member

forki commented Nov 4, 2015

I can reproduce and the error and I understand the issue. hope to provide a fix soon.

@forki forki closed this in 675de6a Nov 4, 2015

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 4, 2015

Member

Please retry with latest
On Nov 4, 2015 02:18, "Marcus Griep" notifications@github.com wrote:

cc: @kolektiv https://github.com/kolektiv


Reply to this email directly or view it on GitHub
#1190 (comment).

Member

forki commented Nov 4, 2015

Please retry with latest
On Nov 4, 2015 02:18, "Marcus Griep" notifications@github.com wrote:

cc: @kolektiv https://github.com/kolektiv


Reply to this email directly or view it on GitHub
#1190 (comment).

@kolektiv

This comment has been minimized.

Show comment
Hide comment
@kolektiv

kolektiv Nov 4, 2015

Just tried the paket update repro and that now doesn't cause a problem. It does change the dependency slightly, but only by a slight expansion of the supported frameworks. A quick glance at xunit and the dependency tree makes me think it's right, which means that if anything I'm guessing this is slightly more correct than before! For the case we discovered this on, it is certainly no longer broken :)

Fantastic work, thanks @forki - and @neoeinstein for tracking it down and reporting!

kolektiv commented Nov 4, 2015

Just tried the paket update repro and that now doesn't cause a problem. It does change the dependency slightly, but only by a slight expansion of the supported frameworks. A quick glance at xunit and the dependency tree makes me think it's right, which means that if anything I'm guessing this is slightly more correct than before! For the case we discovered this on, it is certainly no longer broken :)

Fantastic work, thanks @forki - and @neoeinstein for tracking it down and reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment