New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket does not put .props and .targets import project on correct location in project files #1219

Closed
theggelund opened this Issue Nov 13, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@theggelund

theggelund commented Nov 13, 2015

When Paket installs a nuget package with {packageid}.props/{packageid}.targets in build folder, it should

  1. Put '' as the first child element in Project element
  2. Put '' as the last child element in Project element

Paket puts both imports in the middle of csproj file and by doing so, breaks compatiblity with nuget feature "Import MSBuild targets and props files into project"

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 13, 2015

Member

Do you have a csproj file and a dependencies file (or just nuget package
name) for me to create a integration test?
On Nov 13, 2015 1:29 PM, "Thomas Heggelund" notifications@github.com
wrote:

When Paket installs a nuget package with
{packageid}.props/{packageid}.targets in build folder, it should

  1. Put '' as the first
    child element in Project element
  2. Put '' as the
    last child element in Project element

Paket puts both imports in the middle of csproj file and by doing so,
breaks compatiblity with nuget feature "Import MSBuild targets and props
files into project"


Reply to this email directly or view it on GitHub
#1219.

Member

forki commented Nov 13, 2015

Do you have a csproj file and a dependencies file (or just nuget package
name) for me to create a integration test?
On Nov 13, 2015 1:29 PM, "Thomas Heggelund" notifications@github.com
wrote:

When Paket installs a nuget package with
{packageid}.props/{packageid}.targets in build folder, it should

  1. Put '' as the first
    child element in Project element
  2. Put '' as the
    last child element in Project element

Paket puts both imports in the middle of csproj file and by doing so,
breaks compatiblity with nuget feature "Import MSBuild targets and props
files into project"


Reply to this email directly or view it on GitHub
#1219.

@theggelund

This comment has been minimized.

Show comment
Hide comment

@forki forki added the bug label Nov 13, 2015

@forki forki closed this in 5be086f Nov 13, 2015

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 13, 2015

Member

does this work for you?

Member

forki commented Nov 13, 2015

does this work for you?

@theggelund

This comment has been minimized.

Show comment
Hide comment
@theggelund

theggelund Nov 13, 2015

It worked in the test project and in some of my real projects but not all. I will try to analyze the ones that didn't work and try to create a new test project for you.

theggelund commented Nov 13, 2015

It worked in the test project and in some of my real projects but not all. I will try to analyze the ones that didn't work and try to create a new test project for you.

@forki forki reopened this Nov 13, 2015

@theggelund

This comment has been minimized.

Show comment
Hide comment
@theggelund

theggelund Nov 13, 2015

Updated https://github.com/theggelund/paket_bug

When nuget package is sorted after MultiTarget package => nunit
the import statement comes before nunit import

And I still have the initial issue with some projects.

theggelund commented Nov 13, 2015

Updated https://github.com/theggelund/paket_bug

When nuget package is sorted after MultiTarget package => nunit
the import statement comes before nunit import

And I still have the initial issue with some projects.

@theggelund

This comment has been minimized.

Show comment
Hide comment
@theggelund

theggelund Nov 13, 2015

Updated https://github.com/theggelund/paket_bug

Added a project called manual_project under MyClassLibrary. The initial issue is reproduced with the project. Used latest released paket 2.24.7

theggelund commented Nov 13, 2015

Updated https://github.com/theggelund/paket_bug

Added a project called manual_project under MyClassLibrary. The initial issue is reproduced with the project. Used latest released paket 2.24.7

@forki forki closed this in a65a218 Nov 13, 2015

@forki forki reopened this Nov 13, 2015

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 13, 2015

Member

ok I fixed that Nunit issue

Member

forki commented Nov 13, 2015

ok I fixed that Nunit issue

@forki forki closed this in 6e3792f Nov 13, 2015

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 13, 2015

Member

I hope it's not completely fixed.

Member

forki commented Nov 13, 2015

I hope it's not completely fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment