Breaking visual basic projects on paket update

[Rcomian]

Using paket v2.25.2.0

When upgrading a visual studio project, it moved an import statement to the end of the file:

<Import Project="$(MSBuildToolsPath)\Microsoft.VisualBasic.targets" />

When this import is after the Reference sections, the references are not loaded. As a result, all paket references are effectively removed from the build.

Moving this Import statement further up the file, before the references, fixed the project.

Fortunately, running update again does not appear to automatically break it again.

The move was part of a block move, where a bunch of included files were moved to the end of the file, along with this import statement.

[forki]

@theggelund in #1219 you said the targets should be last stuff in the proj files. seems that#s not correct. what should we do?

[Rcomian]

The statement that was moved was not part of any nuget package. Can we exclude those and not move them?

[forki]

we probably can.

[forki]

do you have the csproj file for me before the change?

[theggelund]

@forki I said that targets that are included in a nuget package (build folder) should be put last, not all targets in a file. Ordering of stuff in msbuild files are important

[forki]

yes. the big question is how can we detect where we want to put our paket references and paket.targets

[Rcomian]

I do, but since we use a lot of internal packages and code I'm not sure how much use they'll be.

BEFORE_NE.SequenceManager.vbproj.txt
AFTER_NE.SequenceManager.vbproj.txt

The AFTER project can be fixed solely by moving the Include line back above the references.

[Rcomian]

Fix looks good - just moving the imports that are controlled by paket.
Can you let me know when there's a build I can try this out on?

[forki]

I'm still trying to reproduce the error, but the latest version has a fix that might help. Could you please retry with latest paket?

[forki]

(and then it's time to cleanup that mess in that function ;-) )

[Rcomian]

Hmm, no, as of 2.25.3.0, it's now leaving the resource files in place, which I like, but the include is still being moved to the end.

AFTER_2.25.3.0.NE.SequenceManager.vbproj.txt

Looking at the code, I'm not sure why that is. I've tried this twice to make sure.

[Rcomian]

And again, moving the include back to its original location (just under the resources, just before the references) works fine.

[forki]

ok. so it's a off by one issue ;-)

[forki]

so seems I was finally able to reproduce this in the integration tests. please retry.

[Rcomian]

That's the one. Tried that and it works fine. Much cleaner and correct set of changes:

AFTER_2.25.4.0.NE.SequenceManager.vbproj.txt

Thank you very much for your work!

[forki]

Cool. Thanks for caring and reporting.