binding redirects from the last group always win. #1284

Closed
Karamell opened this Issue Dec 3, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@Karamell
Contributor

Karamell commented Dec 3, 2015

This is probably related to #1218 .

If i clone paket and then run paket install --redirects (on paket itself) all App.config is rewritten to only contain binding redirects from the last group in the lock file. Easily reproduced.

Am I using packet wrong?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 3, 2015

Member

I don't think this is what's going on. The last group from the lockfile is "Test" and I don't see NUnit Bindings.

Try paket install --redirects --hard and it basically removes all entries since the current logic decides there are no conflicts. The FSharp.Core entries are still needed so we discussed with @mrinaldi that we need a force option.

Member

forki commented Dec 3, 2015

I don't think this is what's going on. The last group from the lockfile is "Test" and I don't see NUnit Bindings.

Try paket install --redirects --hard and it basically removes all entries since the current logic decides there are no conflicts. The FSharp.Core entries are still needed so we discussed with @mrinaldi that we need a force option.

@Karamell

This comment has been minimized.

Show comment
Hide comment
@Karamell

Karamell Dec 3, 2015

Contributor

I'm sorry I misunderstood. The missing FSharp.Core is a different problem.

Try and add modify the app.config-file to this:

<dependentAssembly>
 <bindingRedirect oldVersion="0.0.0.0-999.999.999.999" newVersion="7.0.0.0" />
    <Paket>True</Paket> <!-- important -->
       <bindingRedirect oldVersion="0.0.0.0-999.999.999.999" newVersion="7.0.0.0" />
</dependentAssembly>

you'll see it will be removed.

The next run Paket will first be add the bindings from the Main group, then removed everything in the Build group... and again in the Test group.

the <Paket>True</Paket> concept does not work with groups.

Contributor

Karamell commented Dec 3, 2015

I'm sorry I misunderstood. The missing FSharp.Core is a different problem.

Try and add modify the app.config-file to this:

<dependentAssembly>
 <bindingRedirect oldVersion="0.0.0.0-999.999.999.999" newVersion="7.0.0.0" />
    <Paket>True</Paket> <!-- important -->
       <bindingRedirect oldVersion="0.0.0.0-999.999.999.999" newVersion="7.0.0.0" />
</dependentAssembly>

you'll see it will be removed.

The next run Paket will first be add the bindings from the Main group, then removed everything in the Build group... and again in the Test group.

the <Paket>True</Paket> concept does not work with groups.

forki added a commit that referenced this issue Dec 3, 2015

forki added a commit that referenced this issue Dec 3, 2015

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 3, 2015

Member

tried to fix this in #1286 - @mrinaldi do you think this is correct?

Member

forki commented Dec 3, 2015

tried to fix this in #1286 - @mrinaldi do you think this is correct?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Dec 3, 2015

Member

@Karamell I activated this in 2.23.2 could you please check if it works for you?

Member

forki commented Dec 3, 2015

@Karamell I activated this in 2.23.2 could you please check if it works for you?

@Karamell

This comment has been minimized.

Show comment
Hide comment
@Karamell

Karamell Dec 3, 2015

Contributor

it works for me @forki Both my own project and the paket project is ok.

Thanks for fixing it so fast CI/CD FTW!

Contributor

Karamell commented Dec 3, 2015

it works for me @forki Both my own project and the paket project is ok.

Thanks for fixing it so fast CI/CD FTW!

@forki forki closed this Dec 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment