Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Duplicate references to framework assemblies added #1333
I think this is very similar to #932, if not actually exactly the same thing.
When adding a package to a project using Paket, a
FsXaml and FSharp.Desktop.UI reference the following framework assemblies:
I now use Paket to add those to a project that already references
Adding FSharp.Desktop.UI now inserts the following into the
Next I add FsXaml;
The result is that the respective framework assemblies show up multiple times in Solution Explorer; however, as far as I could see, the project still compiles and runs correctly, probably because they are always references to the exact same thing and thus don't cause conflicts as seen in #932.
My naive first thought would of course be simply putting all references to framework assemblies in normal ItemGroups, but considering we're dealing with Visual Studio, MSBuild and NuGet, that sounds too easy.
I've also already noticed this behavior, but since it leads to no problems during the build and the result assemblies also have no problems at runtime and it's only weird display in the Solution Explorer, I haven't reported this one ;)
To deduplicate the nodes, we would need to collect framework references together with the conditions when each of it should be inserted and provide separate
I have the same behavior. If you add to an empty F# project nuget packages -
Although I have 3
Ok one System.Xml.Linq.dll is coming from FSharp.Data and one from Microsoft.WindowsAzure.Storage
we could somehow store if we already emitted the reference for a given framework and only reference it once. So it would be ommited for Microsoft.WindowsAzure.Storage.
Is it worth it?