-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not download FAKE 4.12.0 #1371
Comments
|
here's the deps file: and lock: |
|
Let's see if we can reproduce. #1372 |
mhm can you check what's blocking? |
|
yes, the nupkage was not in NuGet cache before restore - if I used a previous verison of FAKE that was in the cache, the restore command proceeded just fine |
|
so something blocked that file? |
|
no I checked with procexp and nothing was blocking the file.. I did manage to remove it. For me it seems that the download itself is somehow corrupted, not sure what can be the reason |
|
can you reproduce the behaviour? maybe attach debugger? because I cannot... |
|
nope. not a known issue. |
|
so maybe we need to explictly close the handle somewhere? |
|
I'll try to see if the handle was opened before that line. Also the issue is not rather machine-specific - my collegue encountered the very same problem. |
|
could you please try and see if you can restore FAKE package after removing it from NuGet cache? |
|
hm ok I think I found the issue - I use FAKE also for another paket group, which I did not include per corpo privacy reasons. But I think you should be ablo to repro after boiling down to following: Looks like paket tries to download the package two times, for the main group and for the Deploy group - debugger entered the line with this file twice. |
|
Mhm. Seems we need to extract the download phase then. @vasily-kirichenko Will try to fix this evening.
|
|
I see, thanks and sorry for being such a lazy ass so that I didn't do debug before discovering the real cause ;) |
|
Errors and Failures:
Ok seems in rare situations the test now reproduces |
|
it's not that easy to solve, but 852ee5a might work |
|
could you please test latest? |
Works like a charm! Thanks @forki, this is so awesome |
|
oh wait. there was a perf regression. I made Paket restore every package sequentially. fix is under way |
|
please retry again. just to be sure. |
|
2.42.3.0 works fine for me 👍 |
|
I'm also hitting I wonder if paket could somehow try to recover from this by downloading again the particular nupkg? |
|
I think we currently try 3 times.
|
|
@forki thanks for the info, could you give any precision regarding cache location for custom nuget source? I couldn't find the broken package on my drive. Wondering if there is a chance to make this retry count overrideable in some manner in future release? |
|
Package cache is same folder as nuget
|


Trying to restore packages and I'm getting following in verbose mode:
(looks like it started to download the nupkg but stopped after 360 KB or so)
The text was updated successfully, but these errors were encountered: