New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket 2.53.0 does not add packages named MyLib.MyLib to project #1531

Closed
jschroed opened this Issue Mar 20, 2016 · 14 comments

Comments

Projects
None yet
2 participants
@jschroed

jschroed commented Mar 20, 2016

I noticed an issue starting with Paket version 2.53.0. Paket is no longer adding one my libraries to my projects.

As far as I can tell, the only thing special about this package is that is has the same name before and after the period (e.g. MyLib.MyLib). Did something change in this version of Paket that could cause this?

The previous version 2.52.16 does not give me this issue. Also, version 2.53.0 works fine for all of my other packages.

I have the MyLib.MyLib package in my paket.references, paket.lock, and paket.dependencies. MyLib.MyLib is being downloaded into the packages directory. The only issue seems to be that it is no longer added to my csproj files.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 20, 2016

Member

Can you please try to create a repro case?
On Mar 20, 2016 8:16 PM, "jschroed" notifications@github.com wrote:

I noticed an issue starting with Paket version 2.53.0. Paket is no longer
adding one my libraries to my projects.

As far as I can tell, the only thing special about this package is that is
has the same name before and after the period (e.g. MyLib.MyLib). Did
something change in this version of Paket that could cause this?

The previous version 2.52.16 does not give me this issue. Also, version
2.53.0 works fine for all of my other packages.

I have the MyLib.MyLib package in my paket.references, paket.lock, and
paket.dependencies. MyLib.MyLib is being downloaded into the packages
directory. The only issue seems to be that it is no longer added to my
csproj files.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1531

Member

forki commented Mar 20, 2016

Can you please try to create a repro case?
On Mar 20, 2016 8:16 PM, "jschroed" notifications@github.com wrote:

I noticed an issue starting with Paket version 2.53.0. Paket is no longer
adding one my libraries to my projects.

As far as I can tell, the only thing special about this package is that is
has the same name before and after the period (e.g. MyLib.MyLib). Did
something change in this version of Paket that could cause this?

The previous version 2.52.16 does not give me this issue. Also, version
2.53.0 works fine for all of my other packages.

I have the MyLib.MyLib package in my paket.references, paket.lock, and
paket.dependencies. MyLib.MyLib is being downloaded into the packages
directory. The only issue seems to be that it is no longer added to my
csproj files.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1531

@jschroed

This comment has been minimized.

Show comment
Hide comment
@jschroed

jschroed Mar 20, 2016

Sure, I can try. I'll see if I can find a package on nuget.org that has the same behavior.

jschroed commented Mar 20, 2016

Sure, I can try. I'll see if I can find a package on nuget.org that has the same behavior.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 20, 2016

Member

If not I will try to reproduce tomorrow.
On Mar 20, 2016 8:25 PM, "Steffen Forkmann" sforkmann@gmail.com wrote:

Can you please try to create a repro case?
On Mar 20, 2016 8:16 PM, "jschroed" notifications@github.com wrote:

I noticed an issue starting with Paket version 2.53.0. Paket is no longer
adding one my libraries to my projects.

As far as I can tell, the only thing special about this package is that
is has the same name before and after the period (e.g. MyLib.MyLib). Did
something change in this version of Paket that could cause this?

The previous version 2.52.16 does not give me this issue. Also, version
2.53.0 works fine for all of my other packages.

I have the MyLib.MyLib package in my paket.references, paket.lock, and
paket.dependencies. MyLib.MyLib is being downloaded into the packages
directory. The only issue seems to be that it is no longer added to my
csproj files.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1531

Member

forki commented Mar 20, 2016

If not I will try to reproduce tomorrow.
On Mar 20, 2016 8:25 PM, "Steffen Forkmann" sforkmann@gmail.com wrote:

Can you please try to create a repro case?
On Mar 20, 2016 8:16 PM, "jschroed" notifications@github.com wrote:

I noticed an issue starting with Paket version 2.53.0. Paket is no longer
adding one my libraries to my projects.

As far as I can tell, the only thing special about this package is that
is has the same name before and after the period (e.g. MyLib.MyLib). Did
something change in this version of Paket that could cause this?

The previous version 2.52.16 does not give me this issue. Also, version
2.53.0 works fine for all of my other packages.

I have the MyLib.MyLib package in my paket.references, paket.lock, and
paket.dependencies. MyLib.MyLib is being downloaded into the packages
directory. The only issue seems to be that it is no longer added to my
csproj files.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1531

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 20, 2016

Member

We also have integration tests that create new packages. We could copy and
tweak one of these.
On Mar 20, 2016 8:25 PM, "Steffen Forkmann" sforkmann@gmail.com wrote:

Can you please try to create a repro case?
On Mar 20, 2016 8:16 PM, "jschroed" notifications@github.com wrote:

I noticed an issue starting with Paket version 2.53.0. Paket is no longer
adding one my libraries to my projects.

As far as I can tell, the only thing special about this package is that
is has the same name before and after the period (e.g. MyLib.MyLib). Did
something change in this version of Paket that could cause this?

The previous version 2.52.16 does not give me this issue. Also, version
2.53.0 works fine for all of my other packages.

I have the MyLib.MyLib package in my paket.references, paket.lock, and
paket.dependencies. MyLib.MyLib is being downloaded into the packages
directory. The only issue seems to be that it is no longer added to my
csproj files.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1531

Member

forki commented Mar 20, 2016

We also have integration tests that create new packages. We could copy and
tweak one of these.
On Mar 20, 2016 8:25 PM, "Steffen Forkmann" sforkmann@gmail.com wrote:

Can you please try to create a repro case?
On Mar 20, 2016 8:16 PM, "jschroed" notifications@github.com wrote:

I noticed an issue starting with Paket version 2.53.0. Paket is no longer
adding one my libraries to my projects.

As far as I can tell, the only thing special about this package is that
is has the same name before and after the period (e.g. MyLib.MyLib). Did
something change in this version of Paket that could cause this?

The previous version 2.52.16 does not give me this issue. Also, version
2.53.0 works fine for all of my other packages.

I have the MyLib.MyLib package in my paket.references, paket.lock, and
paket.dependencies. MyLib.MyLib is being downloaded into the packages
directory. The only issue seems to be that it is no longer added to my
csproj files.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1531

@jschroed

This comment has been minimized.

Show comment
Hide comment
@jschroed

jschroed Mar 20, 2016

Okay, that might be best. I couldn't find any packages on nuget that have the same naming scheme. I can look into creating a custom package that has the same behavior but it would take some time.

I think it's an issue with the names but I could be way off. The only other guess I have is that it could an issue with the target framework.

jschroed commented Mar 20, 2016

Okay, that might be best. I couldn't find any packages on nuget that have the same naming scheme. I can look into creating a custom package that has the same behavior but it would take some time.

I think it's an issue with the names but I could be way off. The only other guess I have is that it could an issue with the target framework.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 20, 2016

Member

Ok let's start with the name (but I don't really think it's it). I'll try
to reproduce.

Just to make sure it's not the target framework. Can you mail me the
package? Of course I will keep it private.
On Mar 20, 2016 9:12 PM, "jschroed" notifications@github.com wrote:

Okay, that might be best. I couldn't find any packages on nuget that have
the same naming scheme. I can look into creating a custom package that has
the same behavior but it would take some time.

I think it's an issue with the names but I could be way off. The only
other guess I have is that it could an issue with the target framework.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1531 (comment)

Member

forki commented Mar 20, 2016

Ok let's start with the name (but I don't really think it's it). I'll try
to reproduce.

Just to make sure it's not the target framework. Can you mail me the
package? Of course I will keep it private.
On Mar 20, 2016 9:12 PM, "jschroed" notifications@github.com wrote:

Okay, that might be best. I couldn't find any packages on nuget that have
the same naming scheme. I can look into creating a custom package that has
the same behavior but it would take some time.

I think it's an issue with the names but I could be way off. The only
other guess I have is that it could an issue with the target framework.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1531 (comment)

@jschroed

This comment has been minimized.

Show comment
Hide comment
@jschroed

jschroed Mar 20, 2016

I probably can't email the package since it's work related. I can try to create a similar package, or at least strip out all of the proprietary code.

jschroed commented Mar 20, 2016

I probably can't email the package since it's work related. I can try to create a similar package, or at least strip out all of the proprietary code.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 20, 2016

Member

You could unzip the package and replace all dlls with 0byte dlls with same
name and zip again. We could then even use it for repro if you allow
On Mar 20, 2016 9:57 PM, "jschroed" notifications@github.com wrote:

I probably can't email the package since it's work related. I can try to
create a similar package, or at least strip out all of the proprietary code.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1531 (comment)

Member

forki commented Mar 20, 2016

You could unzip the package and replace all dlls with 0byte dlls with same
name and zip again. We could then even use it for repro if you allow
On Mar 20, 2016 9:57 PM, "jschroed" notifications@github.com wrote:

I probably can't email the package since it's work related. I can try to
create a similar package, or at least strip out all of the proprietary code.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1531 (comment)

@jschroed

This comment has been minimized.

Show comment
Hide comment
@jschroed

jschroed Mar 20, 2016

I can build Paket locally. That might be easier than me trying to get a package to you.

I can diff the two versions of Paket to at least narrow it down. Do you have any debugging that I could add? The verbose option of Paket wasn't any different between the two versions.

jschroed commented Mar 20, 2016

I can build Paket locally. That might be easier than me trying to get a package to you.

I can diff the two versions of Paket to at least narrow it down. Do you have any debugging that I could add? The verbose option of Paket wasn't any different between the two versions.

@jschroed

This comment has been minimized.

Show comment
Hide comment
@jschroed

jschroed Mar 20, 2016

It seems that a change in the Utils.fs caused the issue.

Edit: it's this section. Old code:

    let startPos = path.LastIndexOf (sprintf "%s/" infix)

New code:

    let packagesPos = path.LastIndexOf "packages/"
    let startPos =
        if packagesPos >= 0 then
            path.IndexOf(sprintf "%s/" infix,packagesPos)
        else
            path.LastIndexOf(sprintf "%s/" infix)

jschroed commented Mar 20, 2016

It seems that a change in the Utils.fs caused the issue.

Edit: it's this section. Old code:

    let startPos = path.LastIndexOf (sprintf "%s/" infix)

New code:

    let packagesPos = path.LastIndexOf "packages/"
    let startPos =
        if packagesPos >= 0 then
            path.IndexOf(sprintf "%s/" infix,packagesPos)
        else
            path.LastIndexOf(sprintf "%s/" infix)
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 20, 2016

Member

Ok. Then you are probably very near to a solution. Can you give a whole
path that is now parsed wrongly?
On Mar 20, 2016 10:56 PM, "jschroed" notifications@github.com wrote:

It seems that a change in the Utils.fs caused the issue.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1531 (comment)

Member

forki commented Mar 20, 2016

Ok. Then you are probably very near to a solution. Can you give a whole
path that is now parsed wrongly?
On Mar 20, 2016 10:56 PM, "jschroed" notifications@github.com wrote:

It seems that a change in the Utils.fs caused the issue.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1531 (comment)

@jschroed

This comment has been minimized.

Show comment
Hide comment
@jschroed

jschroed Mar 20, 2016

Looks like the new code is getting "lib/net45" and the old code is just "net45".

EDIT: Here's something close to what I have for a path:

c:/users/username/workspace/myproject/packages/mylib.mylib/lib/net45/mylib.mylib.dll

jschroed commented Mar 20, 2016

Looks like the new code is getting "lib/net45" and the old code is just "net45".

EDIT: Here's something close to what I have for a path:

c:/users/username/workspace/myproject/packages/mylib.mylib/lib/net45/mylib.mylib.dll

@forki forki closed this in b2e68f2 Mar 21, 2016

@forki forki added the bug label Mar 21, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 21, 2016

Member

mhm a dll name ending in lib was already in the testcases. A package name ending in lib was not.
Should be fixed now. Sorry

Member

forki commented Mar 21, 2016

mhm a dll name ending in lib was already in the testcases. A package name ending in lib was not.
Should be fixed now. Sorry

@jschroed

This comment has been minimized.

Show comment
Hide comment
@jschroed

jschroed Mar 21, 2016

No problem. Just glad that we caught this sooner rather than later.

Thanks @forki! Paket 2.53.2 works for us.

jschroed commented Mar 21, 2016

No problem. Just glad that we caught this sooner rather than later.

Thanks @forki! Paket 2.53.2 works for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment