New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects for assemblies in the GAC are removed by paket #1574

Closed
freeranger opened this Issue Apr 6, 2016 · 13 comments

Comments

Projects
None yet
3 participants
@freeranger

freeranger commented Apr 6, 2016

Description

I have a solution which needs this redirect:

<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
      <dependentAssembly>
        <assemblyIdentity name="System.Web.Extensions" publicKeyToken="31bf3856ad364e35" />
        <bindingRedirect oldVersion="1.0.0.0-1.1.0.0" newVersion="4.0.0.0" />
      </dependentAssembly>
    </assemblyBinding>

Which is being removed by paket.

System.Web.Extensions is in the GAC.
I would expect paket to leave along any redirects for GAC registered assemblies by default or at least provide a configuration option where we can specify the redirects we want to keep

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 6, 2016

Member

When is that happening? Can you provide a repro sample? /cc @isaacabraham
On Apr 6, 2016 1:04 PM, "freeranger" notifications@github.com wrote:

Description

I have a solution which needs this redirect:

Which is being removed by paket.

System.Web.Extensions is in the GAC.
I would expect paket to leave along any redirects for GAC registered
assemblies by default or at least provide a configuration option where we
can specify the redirects we want to keep


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1574

Member

forki commented Apr 6, 2016

When is that happening? Can you provide a repro sample? /cc @isaacabraham
On Apr 6, 2016 1:04 PM, "freeranger" notifications@github.com wrote:

Description

I have a solution which needs this redirect:

Which is being removed by paket.

System.Web.Extensions is in the GAC.
I would expect paket to leave along any redirects for GAC registered
assemblies by default or at least provide a configuration option where we
can specify the redirects we want to keep


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1574

@freeranger

This comment has been minimized.

Show comment
Hide comment
@freeranger

freeranger Apr 6, 2016

paket convert-from-nuget --force
is removing all redirects.
the paket.dependencies file only lets you specify keeping redirects for package references, not for GAC references

freeranger commented Apr 6, 2016

paket convert-from-nuget --force
is removing all redirects.
the paket.dependencies file only lets you specify keeping redirects for package references, not for GAC references

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

AFAIK we should not touch GAC references in the redirects.

// @mrinaldi

Member

forki commented Apr 7, 2016

AFAIK we should not touch GAC references in the redirects.

// @mrinaldi

forki added a commit that referenced this issue Apr 7, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

mhm. I tried to reproduce in b099dfe, but test is green. What am I missing?

Member

forki commented Apr 7, 2016

mhm. I tried to reproduce in b099dfe, but test is green. What am I missing?

@freeranger

This comment has been minimized.

Show comment
Hide comment
@freeranger

freeranger Apr 7, 2016

You are doing a paket "install --force" whereas the problem happens when you do a paket convert-from-nuget --force

freeranger commented Apr 7, 2016

You are doing a paket "install --force" whereas the problem happens when you do a paket convert-from-nuget --force

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

@theimowski are we doing something special in that command?

@freeranger can you reset the config files after conversion and rerun install? Does this keep the entries?

Member

forki commented Apr 7, 2016

@theimowski are we doing something special in that command?

@freeranger can you reset the config files after conversion and rerun install? Does this keep the entries?

@freeranger

This comment has been minimized.

Show comment
Hide comment
@freeranger

freeranger Apr 7, 2016

@forki yes, if I re-add them after conversion then they are preserved

freeranger commented Apr 7, 2016

@forki yes, if I re-add them after conversion then they are preserved

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

Ok so it's something we do in convert.
On Apr 7, 2016 2:21 PM, "freeranger" notifications@github.com wrote:

@forki https://github.com/forki yes, if I re-add them after conversion
then they are preserved


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1574 (comment)

Member

forki commented Apr 7, 2016

Ok so it's something we do in convert.
On Apr 7, 2016 2:21 PM, "freeranger" notifications@github.com wrote:

@forki https://github.com/forki yes, if I re-add them after conversion
then they are preserved


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1574 (comment)

@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Apr 7, 2016

Member

update is invoked as the last step in convert: https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/NugetConvert.fs#L392-L395, but it has Force = true; Hard = true; Redirects = true

Member

theimowski commented Apr 7, 2016

update is invoked as the last step in convert: https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/NugetConvert.fs#L392-L395, but it has Force = true; Hard = true; Redirects = true

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

Mhm I guess it's the --hard flag. But I think it should not remove GAC stuff, right?

Member

forki commented Apr 7, 2016

Mhm I guess it's the --hard flag. But I think it should not remove GAC stuff, right?

@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Apr 7, 2016

Member

Can't tell for sure @isaacabraham

Member

theimowski commented Apr 7, 2016

Can't tell for sure @isaacabraham

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 7, 2016

Member

ok confirmed. it's the --hard flag

Member

forki commented Apr 7, 2016

ok confirmed. it's the --hard flag

@forki forki closed this in 2a1d816 Apr 7, 2016

@freeranger

This comment has been minimized.

Show comment
Hide comment
@freeranger

freeranger Apr 7, 2016

Thanks for the quick turnaround fellas - works like a charm now 👍

freeranger commented Apr 7, 2016

Thanks for the quick turnaround fellas - works like a charm now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment