Property Definitions: Placed before FSharp Targets

[ascjones]

Description

After paket install, Websharper targets are moved up above FSharp target import which they depend on, since this commit: 8a9ba04

Guess we need something similar to this fix for CSharp targets: de12ae8

Repro steps

Import FSharp targets like so:

 <!-- F# targets -->
  <Choose>
    <When Condition="'$(VisualStudioVersion)' == '11.0'">
      <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets')">
        <FSharpTargetsPath>$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets</FSharpTargetsPath>
      </PropertyGroup>
    </When>
    <Otherwise>
      <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets')">
        <FSharpTargetsPath>$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets</FSharpTargetsPath>
      </PropertyGroup>
    </Otherwise>
  </Choose>
  <Import Project="$(FSharpTargetsPath)" />

1. run paket install

Expected behavior

Expect the Websharper targets to show up after the FSharp Targets import

Actual behavior

WebSharper Targets show up before the FSharp Targets import

[forki]

which nuget package is that?

[ascjones]

https://www.nuget.org/packages/WebSharper/3.6.11.234

I'm just guessing that it depends on FSharp targets, but anyway it works when the targets import it is below them.

[ascjones]

Yep just confirmed, the WebSharper target import needs to appear after FSharp targets import in order to run, like so:

  <Import Project="$(FSharpTargetsPath)" />
  <Choose>
    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.5.1'">
      <PropertyGroup>
        <__paket__WebSharper_targets>WebSharper</__paket__WebSharper_targets>
      </PropertyGroup>
    </When>
  </Choose>

[forki]

fix is under way

[ascjones]

Fantastic thanks!