New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket could not restore http dependencies to the same directory #1589

Closed
sergey-tihon opened this Issue Apr 10, 2016 · 9 comments

Comments

Projects
None yet
3 participants
@sergey-tihon
Member

sergey-tihon commented Apr 10, 2016

Description

Paket could not restore http dependencies to the same directory

Repro steps

  • paket.dependencies
source https://nuget.org/api/v2

http http://nlp.stanford.edu/software/stanford-ner-2015-12-09.zip
http http://nlp.stanford.edu/software/stanford-segmenter-2015-12-09.zip
  • paket.lock
HTTP
  remote: http://nlp.stanford.edu
  specs:
    stanford-ner-2015-12-09.zip (/software/stanford-ner-2015-12-09.zip)
    stanford-segmenter-2015-12-09.zip (/software/stanford-segmenter-2015-12-09.zip)
  • Execute .paket.restore
  • Execute .paket.restore

Expected behavior

Correct files restore

Actual behavior

Paket version 2.58.9.0
Downloading nlp.stanford.edu/:/software/stanford-ner-2015-12-09.zip stanford-ner-2015-12-09.zip to d:\temp\paket-restore\paket-files\nlp.stanford.edu\stanford-ner-2015-12-09.zip
Downloading nlp.stanford.edu/:/software/stanford-segmenter-2015-12-09.zip stanford-segmenter-2015-12-09.zip to d:\temp\paket-restore\paket-files\nlp.stanford.edu\stanford-segmenter-2015-12-09.zip
Paket failed with:
        Error during deletion of d:\temp\paket-restore\paket-files\nlp.stanford.edu
  - Could not find a part of the path 'd:\temp\paket-restore\paket-files\nlp.stanford.edu'.

Known workarounds

Uses Paket v2.39.8.0

Related information

  • Paket version 2.58.9.0

sergey-tihon added a commit to sergey-tihon/Paket that referenced this issue Apr 10, 2016

@tpetricek

This comment has been minimized.

Show comment
Hide comment
@tpetricek

tpetricek Apr 10, 2016

Member

I think I've seen similar issues (sometimes) when downloading multiple files via file dependencies from the same location.

It smells like some concurrency issue, but I never quite looked into the details.

EDIT But I don't see how this could be happening - the grouping of downloads by target folder should avoid any concurrency issues around the version file and I really don't see anything else that can go wrong there...

Member

tpetricek commented Apr 10, 2016

I think I've seen similar issues (sometimes) when downloading multiple files via file dependencies from the same location.

It smells like some concurrency issue, but I never quite looked into the details.

EDIT But I don't see how this could be happening - the grouping of downloads by target folder should avoid any concurrency issues around the version file and I really don't see anything else that can go wrong there...

@sergey-tihon

This comment has been minimized.

Show comment
Hide comment
@sergey-tihon

sergey-tihon Apr 11, 2016

Member

We have one more CleanDir in the case of downloading zip file.

Member

sergey-tihon commented Apr 11, 2016

We have one more CleanDir in the case of downloading zip file.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 11, 2016

Member

and source.Commit is different so they are not in same group

Member

forki commented Apr 11, 2016

and source.Commit is different so they are not in same group

@forki forki closed this in 9ed9253 Apr 11, 2016

@sergey-tihon

This comment has been minimized.

Show comment
Hide comment
@sergey-tihon

sergey-tihon Apr 11, 2016

Member

Now it is slightly slower than before 2 minutes, 20 seconds vs 1 minute, 53 seconds in old parallel mode.

And it seems that you changed the folder where zip archive will be extracted...

Member

sergey-tihon commented Apr 11, 2016

Now it is slightly slower than before 2 minutes, 20 seconds vs 1 minute, 53 seconds in old parallel mode.

And it seems that you changed the folder where zip archive will be extracted...

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 11, 2016

Member

I don't think we change the folder. But now we see the result of cleandir. it deletes the first thing when the second download happens. try to work around that

Member

forki commented Apr 11, 2016

I don't think we change the folder. But now we see the result of cleandir. it deletes the first thing when the second download happens. try to work around that

@sergey-tihon

This comment has been minimized.

Show comment
Hide comment
@sergey-tihon

sergey-tihon Apr 11, 2016

Member

Yep, you are right. Only one last download in the folder.

Member

sergey-tihon commented Apr 11, 2016

Yep, you are right. Only one last download in the folder.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Apr 11, 2016

Member

and another release...

Member

forki commented Apr 11, 2016

and another release...

@sergey-tihon

This comment has been minimized.

Show comment
Hide comment
@sergey-tihon

sergey-tihon Apr 11, 2016

Member

Seems like paket is OK now.
Thank you @forki

Member

sergey-tihon commented Apr 11, 2016

Seems like paket is OK now.
Thank you @forki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment