Paket could not restore http dependencies to the same directory

[sergey-tihon]

Description

Paket could not restore http dependencies to the same directory

Repro steps

• paket.dependencies

source https://nuget.org/api/v2

http http://nlp.stanford.edu/software/stanford-ner-2015-12-09.zip
http http://nlp.stanford.edu/software/stanford-segmenter-2015-12-09.zip

• paket.lock

HTTP
  remote: http://nlp.stanford.edu
  specs:
    stanford-ner-2015-12-09.zip (/software/stanford-ner-2015-12-09.zip)
    stanford-segmenter-2015-12-09.zip (/software/stanford-segmenter-2015-12-09.zip)

• Execute .paket.restore
• Execute .paket.restore

Expected behavior

Correct files restore

Actual behavior

Paket version 2.58.9.0
Downloading nlp.stanford.edu/:/software/stanford-ner-2015-12-09.zip stanford-ner-2015-12-09.zip to d:\temp\paket-restore\paket-files\nlp.stanford.edu\stanford-ner-2015-12-09.zip
Downloading nlp.stanford.edu/:/software/stanford-segmenter-2015-12-09.zip stanford-segmenter-2015-12-09.zip to d:\temp\paket-restore\paket-files\nlp.stanford.edu\stanford-segmenter-2015-12-09.zip
Paket failed with:
        Error during deletion of d:\temp\paket-restore\paket-files\nlp.stanford.edu
  - Could not find a part of the path 'd:\temp\paket-restore\paket-files\nlp.stanford.edu'.

Known workarounds

Uses Paket v2.39.8.0

Related information

• Paket version 2.58.9.0

[tpetricek]

I think I've seen similar issues (sometimes) when downloading multiple files via file dependencies from the same location.

It smells like some concurrency issue, but I never quite looked into the details.

EDIT But I don't see how this could be happening - the grouping of downloads by target folder should avoid any concurrency issues around the version file and I really don't see anything else that can go wrong there...

[sergey-tihon]

We have one more CleanDir in the case of downloading zip file.

[forki]

@tpetricek the inner thingy is parallel as well: https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/RemoteDownload.fs#L223

[forki]

and source.Commit is different so they are not in same group

[sergey-tihon]

Now it is slightly slower than before 2 minutes, 20 seconds vs 1 minute, 53 seconds in old parallel mode.

And it seems that you changed the folder where zip archive will be extracted...

[forki]

I don't think we change the folder. But now we see the result of cleandir. it deletes the first thing when the second download happens. try to work around that

[sergey-tihon]

Yep, you are right. Only one last download in the folder.

[forki]

and another release...

[sergey-tihon]

Seems like paket is OK now.
Thank you @forki