New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xunit.runner.visualstudio 2.1.0 result in 2.1 in the package folder name when restoring #1708

Closed
ltvan opened this Issue May 28, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@ltvan

ltvan commented May 28, 2016

I use this in my paket:
nuget xunit.runner.visualstudio version_in_path: true

The first paket install, it results in xunit.runner.visualstudio.2.1.0 in packages folder and the .csproj refers to this folder.

The paket restore, it results in xunit.runner.visualstudio.2.1 in packages folder and it breaks the references in .csproj.

The second paket install, it tried to update the reference to xunit.runner.visualsudio.2.1, which is an inconsistant behavior with the first install.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 28, 2016

Member

Are you using latest paket.exe?
On May 28, 2016 02:05, "ltvan" notifications@github.com wrote:

I use this in my paket:
nuget xunit.runner.visualstudio version_in_path: true

The first paket install, it results in xunit.runner.visualstudio.2.1.0 in
packages folder and the .csproj refers to this folder.

The paket restore, it results in xunit.runner.visualstudio.2.1 in packages
folder and it breaks the references in .csproj.

The second paket install, it tried to update the reference to
xunit.runner.visualsudio.2.1, which is an inconsistant behavior with the
first install.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1708, or mute the thread
https://github.com/notifications/unsubscribe/AADgNNwgd8W67n74U2JBhl4wUjRuUGsWks5qF4avgaJpZM4Io8in
.

Member

forki commented May 28, 2016

Are you using latest paket.exe?
On May 28, 2016 02:05, "ltvan" notifications@github.com wrote:

I use this in my paket:
nuget xunit.runner.visualstudio version_in_path: true

The first paket install, it results in xunit.runner.visualstudio.2.1.0 in
packages folder and the .csproj refers to this folder.

The paket restore, it results in xunit.runner.visualstudio.2.1 in packages
folder and it breaks the references in .csproj.

The second paket install, it tried to update the reference to
xunit.runner.visualsudio.2.1, which is an inconsistant behavior with the
first install.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1708, or mute the thread
https://github.com/notifications/unsubscribe/AADgNNwgd8W67n74U2JBhl4wUjRuUGsWks5qF4avgaJpZM4Io8in
.

@ltvan

This comment has been minimized.

Show comment
Hide comment
@ltvan

ltvan May 28, 2016

Yes. I'm using the latest stable version (download by paket.bootstrap.exe)

ltvan commented May 28, 2016

Yes. I'm using the latest stable version (download by paket.bootstrap.exe)

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 30, 2016

Member

I can't reproduce yet.

Can you please create a zip which reproduces the situation just before the second paket install breaks it for you? I will then take a look and try to fix asap.

Member

forki commented May 30, 2016

I can't reproduce yet.

Can you please create a zip which reproduces the situation just before the second paket install breaks it for you? I will then take a look and try to fix asap.

@forki forki added the needs-repro label May 30, 2016

@ltvan

This comment has been minimized.

Show comment
Hide comment
@ltvan

ltvan May 30, 2016

You can see step by step here:
https://github.com/ltvan/PaketWithXUnit

Env: Windows 10, VS2013, VS2015

I run paket install from command line, version 2.66.4.0.

At the third commit, if I delete packages folder and call paket restore, xunit.runner.visualstudio.2.1 will be restored and of course, the .csproj still refer to 2.1.0.

Note that I pinned version 2.1.0 just in case xunit has any upgrade. In my project I don't pin the version, the result is the same.

ltvan commented May 30, 2016

You can see step by step here:
https://github.com/ltvan/PaketWithXUnit

Env: Windows 10, VS2013, VS2015

I run paket install from command line, version 2.66.4.0.

At the third commit, if I delete packages folder and call paket restore, xunit.runner.visualstudio.2.1 will be restored and of course, the .csproj still refer to 2.1.0.

Note that I pinned version 2.1.0 just in case xunit has any upgrade. In my project I don't pin the version, the result is the same.

@forki forki closed this in f805e39 May 30, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 30, 2016

Member

OK thanks. I fixed that and paket will not remove the trailing zero in the lock file when version_in_path is true.

In order to fix your project:

  • update to paket 2.66.5
  • manually fix the paket.lock file to use 2.1.0
  • rerun paket install
Member

forki commented May 30, 2016

OK thanks. I fixed that and paket will not remove the trailing zero in the lock file when version_in_path is true.

In order to fix your project:

  • update to paket 2.66.5
  • manually fix the paket.lock file to use 2.1.0
  • rerun paket install
@ltvan

This comment has been minimized.

Show comment
Hide comment
@ltvan

ltvan May 31, 2016

Thank you very much for your quick fix.

ltvan commented May 31, 2016

Thank you very much for your quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment