New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket does not respect pre-release constraints #1714

Closed
trondd opened this Issue Jun 2, 2016 · 11 comments

Comments

Projects
None yet
2 participants
@trondd
Contributor

trondd commented Jun 2, 2016

Description

The pre-release constraints does not work as described by the documentation

Repro steps

Use the following paket.dependencies file to reproduce the problem.

// Using paket version 2.66.6.0

source https://www.nuget.org/api/v2

// This installs the last release version
//nuget Paket

// ==> paket.lock
//NUGET
//  remote: https://www.nuget.org/api/v2
//  specs:
//    Paket (2.66.6)

// This should not install the pre-release version
// nuget Paket >= 3

// paket.lock
// NUGET
//  remote: https://www.nuget.org/api/v2
//  specs:
//    Paket (3.0.0-beta060)


// This should install the rc, but not the beta version
nuget Paket >= 3 rc

// paket.lock
// NUGET
//  remote: https://www.nuget.org/api/v2
//  specs:
//    Paket (3.0.0-beta060)
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 2, 2016

Member

there is no paket 3 rc!?

Member

forki commented Jun 2, 2016

there is no paket 3 rc!?

@trondd

This comment has been minimized.

Show comment
Hide comment
@trondd

trondd Jun 2, 2016

Contributor

I know, but then I would expect it to fail, and it doesn't.

Contributor

trondd commented Jun 2, 2016

I know, but then I would expect it to fail, and it doesn't.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 2, 2016

Member

there is some addtional stuff happening around prereleases. This is in place because most nuget and myget package combinations are have big issues when it comes to prereleases.

But I agree in this specific case we should probably don't enable this magic. I will take a look

Member

forki commented Jun 2, 2016

there is some addtional stuff happening around prereleases. This is in place because most nuget and myget package combinations are have big issues when it comes to prereleases.

But I agree in this specific case we should probably don't enable this magic. I will take a look

@forki forki added the bug label Jun 2, 2016

@forki forki closed this in 5a50036 Jun 2, 2016

forki added a commit that referenced this issue Jun 2, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 2, 2016

Member

This is now fixed.

Member

forki commented Jun 2, 2016

This is now fixed.

@trondd

This comment has been minimized.

Show comment
Hide comment
@trondd

trondd Jun 2, 2016

Contributor

The problem with testcase 2 still remains: It still install pre-release version. The behavour I would expect is that Paket would only install pre-releases when asked too, and otherwise fail.

Contributor

trondd commented Jun 2, 2016

The problem with testcase 2 still remains: It still install pre-release version. The behavour I would expect is that Paket would only install pre-releases when asked too, and otherwise fail.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 2, 2016

Member

That one is actually much harder to decide.
As I already said there are many situations where people will be broken if we don't be careful.

But I assume we can do the following: if a version restriction is given in deps file then we should not use prereleases. If no version restriction is given then we need to keep everything as we had.

Member

forki commented Jun 2, 2016

That one is actually much harder to decide.
As I already said there are many situations where people will be broken if we don't be careful.

But I assume we can do the following: if a version restriction is given in deps file then we should not use prereleases. If no version restriction is given then we need to keep everything as we had.

@forki forki reopened this Jun 2, 2016

@forki forki closed this in 7285b1b Jun 2, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 2, 2016

Member

can you please retest?

Member

forki commented Jun 2, 2016

can you please retest?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 2, 2016

Member

just to confuse your tests: I released a Paket 3.0 RC1 ;-)

Member

forki commented Jun 2, 2016

just to confuse your tests: I released a Paket 3.0 RC1 ;-)

@trondd

This comment has been minimized.

Show comment
Hide comment
@trondd

trondd Jun 2, 2016

Contributor

Nice! This is much better. I would still consider 3.0.0-rc001 a pre-release, but I understand the backward compatibility argument.

Contributor

trondd commented Jun 2, 2016

Nice! This is much better. I would still consider 3.0.0-rc001 a pre-release, but I understand the backward compatibility argument.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 3, 2016

Member

It is a prerelease. What do you mean?
On Jun 2, 2016 23:27, "Trond Danielsen" notifications@github.com wrote:

Nice! This is much better. I would still consider 3.0.0-rc001 a
pre-release, but I understand the backward compatibility argument.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1714 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNJwbPRhQB4IBoG9d2P5WJ7F3f4Agks5qH0qmgaJpZM4IsfFZ
.

Member

forki commented Jun 3, 2016

It is a prerelease. What do you mean?
On Jun 2, 2016 23:27, "Trond Danielsen" notifications@github.com wrote:

Nice! This is much better. I would still consider 3.0.0-rc001 a
pre-release, but I understand the backward compatibility argument.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1714 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNJwbPRhQB4IBoG9d2P5WJ7F3f4Agks5qH0qmgaJpZM4IsfFZ
.

@trondd

This comment has been minimized.

Show comment
Hide comment
@trondd

trondd Jun 5, 2016

Contributor

Sorry! My mistake, I accidentally tested with an old version. Works like a charm.

Contributor

trondd commented Jun 5, 2016

Sorry! My mistake, I accidentally tested with an old version. Works like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment