New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The required attribute "Condition" is empty or missing from the element <When> #1727

Closed
vbfox opened this Issue Jun 15, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@vbfox
Contributor

vbfox commented Jun 15, 2016

Description

After a paket install under Paket 3.01 (The same solution worked well with 2.62.1) invalid nodes are present in the csproj :

    <When Condition="">
      <ItemGroup>
        <Reference Include="Elasticsearch.Net">
          <HintPath>..\..\packages\Elasticsearch.Net\lib\Elasticsearch.Net.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>

Producing:

MSB4035: foo.csproj(10,5): The required attribute "Condition" is empty or missing from the element .

Repro steps

  1. Get the files from https://gist.github.com/vbfox/94a1eb1f9fdff79af17f7b6168b61c8e
  2. Run paket install.
  3. Notice that <When Condition=""> is generated.

Expected behavior

A valid project is generated.

Actual behavior

MsBuild complains & refuse to build.

Known workarounds

The bug seem related to the framework filtering feature, removing framework: >= net451 from paket.dependencies generate a valid (if bloated) project file.

@forki forki closed this in 8f862a4 Jun 15, 2016

@forki forki added the bug label Jun 15, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 15, 2016

Member

this was related to runtime dependency stuff.

Member

forki commented Jun 15, 2016

this was related to runtime dependency stuff.

@vbfox

This comment has been minimized.

Show comment
Hide comment
@vbfox

vbfox Jun 15, 2016

Contributor

That seem solved !

Contributor

vbfox commented Jun 15, 2016

That seem solved !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment