New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Downloading Licence #1741

Closed
matthid opened this Issue Jun 19, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@matthid
Member

matthid commented Jun 19, 2016

Description

Paket 3 cannot download "Yaaf.AdvancedBuilding == 1.14.0"

redirects on
source https://nuget.org/api/v2
nuget Yaaf.AdvancedBuilding == 0.14.0

Expected behavior

Download the package

Actual behavior

$ .paket/paket.exe update
Paket version 3.1.5.0
Resolving packages for group Main:
 - Yaaf.AdvancedBuilding 0.14.0
 - FAKE 4.29.0
 - FSharp.Formatting 2.14.4
 - FSharpVSPowerTools.Core 2.3.0
 - FSharp.Compiler.Service 2.0.0.6
C:\PROJ\Yaaf.FSharp.Scripting\paket.lock is already up-to-date
Something went wrong while downloading Yaaf.AdvancedBuilding 0.14.0
Message: Could not find a part of the path.
  ==> Trying again
Downloading Yaaf.AdvancedBuilding 0.14.0
Something went wrong while downloading Yaaf.AdvancedBuilding 0.14.0
Message: Could not find a part of the path.
  ==> Last trial
Downloading Yaaf.AdvancedBuilding 0.14.0
Paket failed with:
        Could not find a part of the path.



Downloading license for Yaaf.AdvancedBuilding 0.14.0 to C:\Users\dragon\AppData\Local\NuGet\Cache\Yaaf.AdvancedBuilding.0.14.0.license.html
Paket failed with:
        Could not find a part of the path.
StackTrace:
     at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.File.InternalMove(String sourceFileName, String destFileName, Boolean checkHost)
   at Paket.NuGetV2.cleanup(DirectoryInfo dir)
   at Paket.NuGetV2.ExtractPackage@428-12.Invoke(Unit unitVar)
   at Microsoft.FSharp.Control.AsyncBuilderImpl.callA@851.Invoke(AsyncParams`1 args)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.FSharp.Control.AsyncBuilderImpl.commit[a](Result`1 res)
   at Microsoft.FSharp.Control.CancellationTokenOps.RunSynchronously[a](CancellationToken token, FSharpAsync`1 computation, FSharpOption`1 timeout)
   at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken)
   at Microsoft.FSharp.Collections.IEnumerator.map@111.DoMoveNext(b& )
   at Microsoft.FSharp.Collections.IEnumerator.MapEnumerator`1.System-Collections-IEnumerator-MoveNext()
   at Microsoft.FSharp.Core.CompilerServices.RuntimeHelpers.takeOuter@713[T,TResult](ConcatEnumerator`2 x, Unit unitVar0)
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at Microsoft.FSharp.Collections.SeqModule.ToArray[T](IEnumerable`1 source)
   at Paket.InstallProcess.InstallIntoProjects[a](InstallerOptions options, Boolean forceTouch, DependenciesFile dependenciesFile, LockFile lockFile, FSharpList`1 projectsAndReferences, FSharpMap`2 updatedGroups)
   at Paket.UpdateProcess.SmartInstall(DependenciesFile dependenciesFile, UpdateMode updateMode, UpdaterOptions options)
   at <StartupCode$Paket-Core>.$PublicAPI.Update@194.Invoke(Unit unitVar0)
   at Paket.Utils.RunInLockedAccessMode[a](String rootFolder, FSharpFunc`2 action)
   at Paket.Program.handler@416-16.Invoke(ParseResults`1 results)
   at Paket.Program.processWithValidation[T](FSharpFunc`2 validateF, FSharpFunc`2 commandF, Command command, String[] args)
   at Paket.Program.processCommand@61-1.Invoke(Command command, String[] args)
   at Paket.Program.main()

Known workarounds

None

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 19, 2016

Member

any ideas what is going wrong?

Member

forki commented Jun 19, 2016

any ideas what is going wrong?

@forki forki closed this in 19923de Jun 20, 2016

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 20, 2016

Member

Please retry

Member

forki commented Jun 20, 2016

Please retry

@forki forki added the bug label Jun 20, 2016

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jun 23, 2016

Member

I have no idea whats going on and I still have this with 3.1.9.0. I might be able to take a look at the weekend.

Member

matthid commented Jun 23, 2016

I have no idea whats going on and I still have this with 3.1.9.0. I might be able to take a look at the weekend.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 23, 2016

Member

Argh. I fixed the one I reproduced. But seems there is more.
On Jun 23, 2016 8:10 PM, "Matthias Dittrich" notifications@github.com
wrote:

I have no idea whats going on and I still have this with 3.1.9.0. I might
be able to take a look at the weekend.


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#1741 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNL-080twKFKkSPKIR0bwEbElej5zks5qOsv8gaJpZM4I5LJx
.

Member

forki commented Jun 23, 2016

Argh. I fixed the one I reproduced. But seems there is more.
On Jun 23, 2016 8:10 PM, "Matthias Dittrich" notifications@github.com
wrote:

I have no idea whats going on and I still have this with 3.1.9.0. I might
be able to take a look at the weekend.


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#1741 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNL-080twKFKkSPKIR0bwEbElej5zks5qOsv8gaJpZM4I5LJx
.

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jun 24, 2016

Member

paket_error_1741

Before fixing: Any idea why we use Uri.UnescapeDataString? Should such paths be supported (looks like my package is just invalid, but there might be a paket bug as well)?

Member

matthid commented Jun 24, 2016

paket_error_1741

Before fixing: Any idea why we use Uri.UnescapeDataString? Should such paths be supported (looks like my package is just invalid, but there might be a paket bug as well)?

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jun 24, 2016

Member

BTW: The package was build by nuget.exe on linux. Seems like they regressed some path bug. Feels like its time to switch to paket pack :)

Member

matthid commented Jun 24, 2016

BTW: The package was build by nuget.exe on linux. Seems like they regressed some path bug. Feels like its time to switch to paket pack :)

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 24, 2016

Member

I think replace these paths later in some cleanup function.

Member

forki commented Jun 24, 2016

I think replace these paths later in some cleanup function.

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jun 24, 2016

Member

I'm not sure I understand. Basically the question is how we want to handle files with \ in their name (which is a valid character on unix).

  • Should we just throw here and tell the user that they should package their stuff in way to be compatible across platforms?
  • Throw a better error message on windows?
  • Replace \ with / and make it work the same on both platforms?
  • Have different behavior on both platforms (= create the file on unix and the folder on Windows)
Member

matthid commented Jun 24, 2016

I'm not sure I understand. Basically the question is how we want to handle files with \ in their name (which is a valid character on unix).

  • Should we just throw here and tell the user that they should package their stuff in way to be compatible across platforms?
  • Throw a better error message on windows?
  • Replace \ with / and make it work the same on both platforms?
  • Have different behavior on both platforms (= create the file on unix and the folder on Windows)
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jun 24, 2016

Member

Tbh I have no idea. If we can make it reliably work then silently
"patching" the package is fine.
On Jun 24, 2016 6:03 PM, "Matthias Dittrich" notifications@github.com
wrote:

I'm not sure I understand. Basically the question is how we want to handle
files with \ in their name (which is a valid character on unix).

  • Should we just throw here and tell the user that they should package
    their stuff in way to be compatible across platforms?
  • Throw a better error message on windows?
  • Replace \ with / and make it work the same on both platforms?
  • Have different behavior on both platforms (= create the file on unix
    and the folder on Windows)


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1741 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNO6fE1ktLsoWHck1dZigz3IJn0sdks5qO__ZgaJpZM4I5LJx
.

Member

forki commented Jun 24, 2016

Tbh I have no idea. If we can make it reliably work then silently
"patching" the package is fine.
On Jun 24, 2016 6:03 PM, "Matthias Dittrich" notifications@github.com
wrote:

I'm not sure I understand. Basically the question is how we want to handle
files with \ in their name (which is a valid character on unix).

  • Should we just throw here and tell the user that they should package
    their stuff in way to be compatible across platforms?
  • Throw a better error message on windows?
  • Replace \ with / and make it work the same on both platforms?
  • Have different behavior on both platforms (= create the file on unix
    and the folder on Windows)


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1741 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNO6fE1ktLsoWHck1dZigz3IJn0sdks5qO__ZgaJpZM4I5LJx
.

matthid added a commit to matthid/Paket that referenced this issue Jun 24, 2016

forki added a commit that referenced this issue Jun 25, 2016

Merge pull request #1755 from matthid/fix_1741
fix #1741 by trying to repair the file paths and writing a warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment