New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use colons in git build argument #1773

Closed
TMVector opened this Issue Jun 29, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@TMVector

Description

When using the build script functionality of git sources in paket.dependencies, the command and argument cannot contain colons. E.g.

git https://github.com/user/repo.git master build: "xbuild /p:Configuration=Release"

I would expect for commas to be a problem too.

I believe the code that causes this is Utils.parseKeyValuePairs. If you think it's a problem worth solving, I am happy to work on a patch, but I didn't want to create a PR without checking first.

Repro steps

  1. Add this line to paket.dependencies

    git https://github.com/chmorgan/sharppcap.git master build: "xbuild /p:Configuration=Release"
    
  2. Run $ .paket/paket.exe install

Expected behavior

Command runs as expected.

Actual behavior

Paket prints an error message:

Paket version 3.3.6.0
Paket failed with:
    Error in paket.dependencies line 4
  Could not parse build: "xbuild /p:Configuration=Release" as key/value pairs.
"build: "xbuild /p:Configuration=Release"" can not be parsed as key/value pairs.

Known workarounds

None known.

Tried using $(echo -e '\x3A') in place of the colon, but it has no effect.

Related information

  • Ubuntu 14.04 LTS x64
  • Paket 3.3.6.0
  • Mono 4.2.4

@forki forki closed this in dcb0208 Jun 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment