New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-duplicate framework dependencies get removed #1888

Closed
Stift opened this Issue Aug 25, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@Stift
Contributor

Stift commented Aug 25, 2016

Description

Framework Dependencies get removed from project files when running paket install. With paket 3.12.0 and later!

Repro steps

We have a package which depends on different framework deps (e.g. System.Configuration, System.IdentityModel, System.Runtime.Serialization, System.Web, System.XML, System.XML.Serialization). Another package has some similar dependencies (System.Configuration, System.IdentityModel, System.ServiceProcess).
When running paket install the references get removed despite the project has no dependencies defined neither the other packages. Somehow all dependencies of dependent packages won't be used.
After some investigation I think the wrong behaviour is, when there is a duplicate framework-dependency, all framework-dependencies get removed. In the case above I would assume that System.ServiceProcess should stay which is not.

The repo attached can be used to replay that.
demo160824.zip

Expected behavior

Dependencies should stay as they are. Only remove the duplicates

Known workarounds

Use Version 3.11.3 and lower. It seems with the fix of bug #1333 this behaviour was introduced.

Related information

  • Windows 7
  • 3.12.0 and later
  • .NET Runtime

@forki forki closed this in db31d2e Aug 25, 2016

@Stift

This comment has been minimized.

Show comment
Hide comment
@Stift

Stift Aug 25, 2016

Contributor

Works well. Thx.

Contributor

Stift commented Aug 25, 2016

Works well. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment