New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Dependency fails to install when space exists in User Folder name #2015

Closed
granttrevor opened this Issue Nov 10, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@granttrevor

granttrevor commented Nov 10, 2016

Description

I have a user folder that has a space in it eg: C:\Users\Firstname Lastname
Git dependency resolution fails when attempting to clone from C:\Users\Firstname Lastname.paket\git\db\folder into the paket-files folder.

It correctly fetches the repository from a remote github based repo into C:\Users\Firstname Lastname.paket\git\db\folder

Repro steps

Please provide the steps required to reproduce the problem

  1. Create a User with a Space in their User name, this will create a User folder that contains a space

  2. Add git dependency in paket.dependencies

git git@github.com:MyOrganisation/MyRepo.git master build: "powershell build.ps1"

  1. run packet.exe install

Expected behavior

Dependency should be installed in packet-files

Actual behavior

Paket failed with:
Checkout to C:\Working\MySolution\MyProject\paket-files\github.com\MyOrganisation\MyRepo failed.
Message: Could not run "git clone file:///C:\Users\Firstname Lastname.paket\git\db\MyRepo".
Error:
Cloning into 'Lastname.paket\git\db\MyRepo'...
fatal: 'C:/Users/Firstname' does not appear to be a git repository
fatal: Could not read from remote repository.

Known workarounds

None

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 11, 2016

Member

you don't have a existing git url for me?

Member

forki commented Nov 11, 2016

you don't have a existing git url for me?

@forki forki added the needs-repro label Nov 11, 2016

@granttrevor

This comment has been minimized.

Show comment
Hide comment
@granttrevor

granttrevor Nov 14, 2016

I've created a test repo - https://github.com/wzowee/paket-test and stuck the Serilog nuget package in the root which you could use to test the pulling down from a git source.

Just to be clear the issue is with the name of the User folder on a Windows machine if this name has a space in it then the clone from the .paket folder with the user folder fails.

granttrevor commented Nov 14, 2016

I've created a test repo - https://github.com/wzowee/paket-test and stuck the Serilog nuget package in the root which you could use to test the pulling down from a git source.

Just to be clear the issue is with the name of the User folder on a Windows machine if this name has a space in it then the clone from the .paket folder with the user folder fails.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 14, 2016

Member

argh. so I need to create a windows user with space. ok let me try that.

Member

forki commented Nov 14, 2016

argh. so I need to create a windows user with space. ok let me try that.

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Nov 14, 2016

Member

Windows username with a space is basically asking for trouble ;)
@forki Try to add some special characters as well, heard lots of funny stories in the past.

Member

matthid commented Nov 14, 2016

Windows username with a space is basically asking for trouble ;)
@forki Try to add some special characters as well, heard lots of funny stories in the past.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 14, 2016

Member

@matthid I will not! ;-)

Member

forki commented Nov 14, 2016

@matthid I will not! ;-)

@forki forki closed this in 63cd015 Nov 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment