New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket 4.0 Conver from nuget with wildcard version #2185

Closed
vilinski opened this Issue Mar 15, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@vilinski

Description

paket convert-from-nuget, can't recognize the FSharp.Core (and other) version with wildcards

Repro steps

At first, thank you very much for new fsproj support! Very sorry not tried as it was in alpha.
The repro steps with actual .NET CLI:

dotnet new sln
dotnet new console -lang f# -o src/TheProgram
dotnet new console -lang f# -o src/TheProgram.Test
dotnet sln add src/**/*.fsproj
dotnet restore
dotnet build
dotnet run --project src/TheProgram/TheProgram.fsproj
# download paket 4.0 release to ./.paket/
.paket/paket.exe convert-from-nuget

Expected behavior

Naive imagination it converts the core projects from nuget to paket.

Actual behavior

error: input string has wrong format (german)

Paket version 4.0.0
Paket failed with:
        Can't parse "4.1.*".
Die Eingabezeichenfolge hat das falsche Format.

Known workarounds

Use versions without wildcards.

  • FShar.Core version 4.1.* -> 4.1.0.2
  • FSharp.NET.Sdk to 1.0.* -> 1.0.1
  • Same with other packages, if any
.paket/paket.exe convert-from-nuget
Paket version 4.0.0
Adding package FSharp.Core to C:\git\gitlocal\coremongo\src\TheProgram\paket.references into group Main
Adding package FSharp.NET.Sdk to C:\git\gitlocal\coremongo\src\TheProgram\paket.references into group Main
Adding package FSharp.Core to C:\git\gitlocal\coremongo\src\TheProgram.Test\paket.references into group Main
Adding package FSharp.NET.Sdk to C:\git\gitlocal\coremongo\src\TheProgram.Test\paket.references into group Main
Dependencies files saved to C:\git\gitlocal\coremongo\paket.dependencies
References file saved to C:\git\gitlocal\coremongo\src\TheProgram\paket.references
References file saved to C:\git\gitlocal\coremongo\src\TheProgram.Test\paket.references
Resolving packages for group Main:
 - FSharp.Core is pinned to 4.1.0.2
 - FSharp.NET.Sdk is pinned to 1.0.1
 - System.ValueTuple 4.3.0
 - FSharp.Compiler.Tools 4.1.0
 - System.IO 4.3.0
 - System.Linq 4.3.0
 - System.Linq.Expressions 4.3.0
 - System.Reflection 4.3.0
 - System.Runtime 4.3.0
 ...

In this case it starts to convert, but does it veeeery slow, which may be another related issue.
It still runs..... Has not yet created the paket.lock file, only the paket.references and paket.dependencies:

source https://dotnet.myget.org/F/dotnet-core/api/v3/index.json
source https://dotnet.myget.org/F/cli-deps/api/v3/index.json
source https://api.nuget.org/v3/index.json

nuget FSharp.Core 4.1.0.2
nuget FSharp.NET.Sdk 1.0.1
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 15, 2017

Member

/cc @theimowski do we already support convert for MSBuild 15?

Member

forki commented Mar 15, 2017

/cc @theimowski do we already support convert for MSBuild 15?

@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Mar 15, 2017

Member

Sorry, I've lately been and will be for a while off, not catching up to the latest stories from dotnet world.
Convert should deal with new PackageReference, but probably can't handle wildcards, no.
So how the wildcards work? Can you think of 4.1.* as of ~> 4.1 in Paket ?

Member

theimowski commented Mar 15, 2017

Sorry, I've lately been and will be for a while off, not catching up to the latest stories from dotnet world.
Convert should deal with new PackageReference, but probably can't handle wildcards, no.
So how the wildcards work? Can you think of 4.1.* as of ~> 4.1 in Paket ?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Mar 16, 2017

Member

can you please add a zip with the repo exactly before paket convert?

Member

forki commented Mar 16, 2017

can you please add a zip with the repo exactly before paket convert?

@vilinski

This comment has been minimized.

Show comment
Hide comment

@forki forki closed this in b7fa92d Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment