New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DependencyChange detection is wrong for runtime graph #2334

Closed
forki opened this Issue May 13, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@forki
Member

forki commented May 13, 2017

  • Create a project as described in #2233

run paket restore and dependency change detection will go crazy on it. Basically every package will be reported as "not in deps file". I think the issue is that GetTransitiveDependencies is calculating wrong result.

Basically that function looks into all nuspecs and computes union of all deps. But since runtime dependency resolution we retrieve deps from within the package. So this is no longer correct.

@matthid any chance you could fix that function?

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid May 13, 2017

Member

Oh crap. Yes I will fix this, but probably in a week (or maybe tomorrow).

Basically I think it just needs to ignore deps in the lockfile which are marked with isRuntimeDependency: true

Member

matthid commented May 13, 2017

Oh crap. Yes I will fix this, but probably in a week (or maybe tomorrow).

Basically I think it just needs to ignore deps in the lockfile which are marked with isRuntimeDependency: true

@forki forki closed this in cd501c8 May 13, 2017

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid May 13, 2017

Member

nice, thanks!

Member

matthid commented May 13, 2017

nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment