New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.net core project stripped of all references #2518

Closed
stimms opened this Issue Jul 13, 2017 · 9 comments

Comments

Projects
None yet
4 participants
@stimms

stimms commented Jul 13, 2017

Description

The .csproj file for a .net core project is not updated with any references either during a nuget conversion or when adding a package.

Repro steps

Please provide the steps required to reproduce the problem

  1. Create a new ASP.NET Core project in Visual Studio
  2. Add the paket bootstrap at the solution level
  3. In the project directory run .paket/paket.exe convert-from-nuget
  4. Attempt to build in Visual Studio

https://github.com/stimms/PaketReferenceBug

Expected behaviour

Project references the packages listed as dependencies.

Actual behaviour

The project has no references to any libraries and cannot be built.

Known workarounds

No trivial workaround

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 13, 2017

Member

I think we would need it BEFORE the conversion

Member

forki commented Jul 13, 2017

I think we would need it BEFORE the conversion

@stimms

This comment has been minimized.

Show comment
Hide comment
@stimms

stimms Jul 13, 2017

Sorry, you'd need what before the conversion?

stimms commented Jul 13, 2017

Sorry, you'd need what before the conversion?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 13, 2017

Member

the situation just before you run convert.

Member

forki commented Jul 13, 2017

the situation just before you run convert.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 13, 2017

Member

can you upload a zip with that?

Member

forki commented Jul 13, 2017

can you upload a zip with that?

@stimms

This comment has been minimized.

Show comment
Hide comment
@stimms

stimms commented Jul 13, 2017

It is just file > new project. I put it in https://github.com/stimms/PaketReferenceBug/tree/before_conversion

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 14, 2017

Member

I get a paket.dependencies file with

source C:\Users\Steffen\.dotnet\NuGetFallbackFolder
source https://www.nuget.org/api/v2/

nuget Microsoft.ApplicationInsights.AspNetCore 2.0.0
nuget Microsoft.AspNetCore 1.1.2
nuget Microsoft.AspNetCore.Mvc 1.1.3
nuget Microsoft.AspNetCore.StaticFiles 1.1.2
nuget Microsoft.Extensions.Logging.Debug 1.1.2
nuget Microsoft.VisualStudio.Web.BrowserLink 1.1.2

and paket.references with

Microsoft.ApplicationInsights.AspNetCore
Microsoft.AspNetCore
Microsoft.AspNetCore.Mvc
Microsoft.AspNetCore.StaticFiles
Microsoft.Extensions.Logging.Debug
Microsoft.VisualStudio.Web.BrowserLink

that looks mostly correct.

source C:\Users\Steffen\.dotnet\NuGetFallbackFolder

is probably not something I want to remove and cli tool conversion could be done. But what are you missing?

Member

forki commented Jul 14, 2017

I get a paket.dependencies file with

source C:\Users\Steffen\.dotnet\NuGetFallbackFolder
source https://www.nuget.org/api/v2/

nuget Microsoft.ApplicationInsights.AspNetCore 2.0.0
nuget Microsoft.AspNetCore 1.1.2
nuget Microsoft.AspNetCore.Mvc 1.1.3
nuget Microsoft.AspNetCore.StaticFiles 1.1.2
nuget Microsoft.Extensions.Logging.Debug 1.1.2
nuget Microsoft.VisualStudio.Web.BrowserLink 1.1.2

and paket.references with

Microsoft.ApplicationInsights.AspNetCore
Microsoft.AspNetCore
Microsoft.AspNetCore.Mvc
Microsoft.AspNetCore.StaticFiles
Microsoft.Extensions.Logging.Debug
Microsoft.VisualStudio.Web.BrowserLink

that looks mostly correct.

source C:\Users\Steffen\.dotnet\NuGetFallbackFolder

is probably not something I want to remove and cli tool conversion could be done. But what are you missing?

forki added a commit that referenced this issue Jul 14, 2017

@inosik

This comment has been minimized.

Show comment
Hide comment
@inosik

inosik Jul 14, 2017

Contributor

@stimms I think that is by purpose, because Paket "replaces" PackageReference items in the project with paket.dependencies and paket.references.

I think all you are missing is a simple dotnet restore after Step 3. @forki shouldn't that be working?

Contributor

inosik commented Jul 14, 2017

@stimms I think that is by purpose, because Paket "replaces" PackageReference items in the project with paket.dependencies and paket.references.

I think all you are missing is a simple dotnet restore after Step 3. @forki shouldn't that be working?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 14, 2017

Member

@inosik I have currently no idea what the bug is about. But I improved convert to understand cli references as well :P

Member

forki commented Jul 14, 2017

@inosik I have currently no idea what the bug is about. But I improved convert to understand cli references as well :P

@enricosada

This comment has been minimized.

Show comment
Hide comment
@enricosada

enricosada Jan 23, 2018

Collaborator

Closing as fixed

Collaborator

enricosada commented Jan 23, 2018

Closing as fixed

@enricosada enricosada closed this Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment