New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paket find-packages with empty arg is broken when using the bootstrapper #2545

Closed
agross opened this Issue Jul 20, 2017 · 13 comments

Comments

Projects
None yet
2 participants
@agross
Contributor

agross commented Jul 20, 2017

Description

paket find-packages '' is used to search for top packages to provide completion. This has been working with 5.5 but seems broken now.

Repro steps

Please provide the steps required to reproduce the problem

  1. paket find-packages ''
  2. paket enters interactive mode when it should find top packages

Expected behavior

Top packages should be listed

Actual behavior

Interactive mode is entered

@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 20, 2017

Contributor

Could be a breaking change in NuGet, seems like search doesn't work at all.

$ paket find-packages "FA"
Paket version 5.79.3
Ignoring error when requesting 'https://www.nuget.org/api/v2': Request to 'https://api.nuget.org/v3-flatcontainer/?q=FA&take=10000' failed with: 'BadRequest'
Performance:
 - Average Request Time: 778 milliseconds
 - Number of Requests: 3
 - Runtime: 3 seconds
Contributor

agross commented Jul 20, 2017

Could be a breaking change in NuGet, seems like search doesn't work at all.

$ paket find-packages "FA"
Paket version 5.79.3
Ignoring error when requesting 'https://www.nuget.org/api/v2': Request to 'https://api.nuget.org/v3-flatcontainer/?q=FA&take=10000' failed with: 'BadRequest'
Performance:
 - Average Request Time: 778 milliseconds
 - Number of Requests: 3
 - Runtime: 3 seconds
@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 20, 2017

Contributor

5.5.3 is the last version that works.

Contributor

agross commented Jul 20, 2017

5.5.3 is the last version that works.

@agross agross changed the title from paket find-packages with empty argument is broken to paket find-packages is broken Jul 20, 2017

@forki forki closed this in d4e5e7e Jul 20, 2017

@agross agross reopened this Jul 20, 2017

@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 20, 2017

Contributor

paket find-packages "" doesn't work yet

Contributor

agross commented Jul 20, 2017

paket find-packages "" doesn't work yet

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 20, 2017

Member

For me it is working:

{ simplenugetserverpaketrepro } master » .paket/paket.exe find-packages ""                                                                                                                            /c/proj/simplenugetserverpaketrepro
Paket version 5.80.0
Ignoring error when requesting 'http://localhost:5000': Could not retrieve data from 'http://localhost:5000/Packages()?$filter=IsLatestVersion and IsAbsoluteLatestVersion and substringof('',tolower(Id))'
Newtonsoft.Json
NUnit
EntityFramework
jQuery
bootstrap
AutoMapper
NUnit.Runners
Microsoft.AspNet.Mvc
log4net
NuGet.Core
Npgsql
HtmlAgilityPack
SlowCheetah.Xdt
Microsoft.Owin.Host.SystemWeb
NLog
Microsoft.AspNet.SignalR
Microsoft.AspNet.WebApi
jQuery.UI.Combined
AjaxControlToolkit
angularjs
Performance:
 - Average Request Time: 429 milliseconds
 - Number of Requests: 3
 - Runtime: 2 seconds
Member

matthid commented Jul 20, 2017

For me it is working:

{ simplenugetserverpaketrepro } master » .paket/paket.exe find-packages ""                                                                                                                            /c/proj/simplenugetserverpaketrepro
Paket version 5.80.0
Ignoring error when requesting 'http://localhost:5000': Could not retrieve data from 'http://localhost:5000/Packages()?$filter=IsLatestVersion and IsAbsoluteLatestVersion and substringof('',tolower(Id))'
Newtonsoft.Json
NUnit
EntityFramework
jQuery
bootstrap
AutoMapper
NUnit.Runners
Microsoft.AspNet.Mvc
log4net
NuGet.Core
Npgsql
HtmlAgilityPack
SlowCheetah.Xdt
Microsoft.Owin.Host.SystemWeb
NLog
Microsoft.AspNet.SignalR
Microsoft.AspNet.WebApi
jQuery.UI.Combined
AjaxControlToolkit
angularjs
Performance:
 - Average Request Time: 429 milliseconds
 - Number of Requests: 3
 - Runtime: 2 seconds
@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 20, 2017

Contributor

Hm, for me it's not:

cmd.exe:

$ .paket/paket.exe find-packages ""
Paket version 5.80.0
 - Please enter search text (:q for exit):

zsh/bash:

$ .paket/paket.exe find-packages ""
Paket version 5.80.0
 - Please enter search text (:q for exit):
:q

$ .paket/paket.exe find-packages ''
Paket version 5.80.0
 - Please enter search text (:q for exit):
Contributor

agross commented Jul 20, 2017

Hm, for me it's not:

cmd.exe:

$ .paket/paket.exe find-packages ""
Paket version 5.80.0
 - Please enter search text (:q for exit):

zsh/bash:

$ .paket/paket.exe find-packages ""
Paket version 5.80.0
 - Please enter search text (:q for exit):
:q

$ .paket/paket.exe find-packages ''
Paket version 5.80.0
 - Please enter search text (:q for exit):
@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 20, 2017

Contributor

Do you use magic mode? It seems that the arg is lost in translation:

2017-07-20_23-00-20

Contributor

agross commented Jul 20, 2017

Do you use magic mode? It seems that the arg is lost in translation:

2017-07-20_23-00-20

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 20, 2017

Member

no I did not in my tests, so yes that could be the reason...

Member

matthid commented Jul 20, 2017

no I did not in my tests, so yes that could be the reason...

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 20, 2017

Member

Thanks for posting so quickly, was trying every shell I could find, and all were working ;)

Member

matthid commented Jul 20, 2017

Thanks for posting so quickly, was trying every shell I could find, and all were working ;)

@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 20, 2017

Contributor

Tested again with the latest bootstrapper. No dice.

Contributor

agross commented Jul 20, 2017

Tested again with the latest bootstrapper. No dice.

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 20, 2017

Member

So technically it's a different issue which was there ever since magic mode was introduced I guess?

Member

matthid commented Jul 20, 2017

So technically it's a different issue which was there ever since magic mode was introduced I guess?

@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 20, 2017

Contributor

Probably, yes. During completion development I only tested against locally compiled paket.exes since I required args that were not released yet.

Contributor

agross commented Jul 20, 2017

Probably, yes. During completion development I only tested against locally compiled paket.exes since I required args that were not released yet.

@agross agross changed the title from paket find-packages is broken to paket find-packages with empty arg is broken when using the bootstrapper Jul 20, 2017

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Jul 20, 2017

Member

Can we open a new one? I'd like to keep that one as a reminder to add a regression test for the initial issue.

Member

matthid commented Jul 20, 2017

Can we open a new one? I'd like to keep that one as a reminder to add a regression test for the initial issue.

@agross

This comment has been minimized.

Show comment
Hide comment
@agross

agross Jul 20, 2017

Contributor

Or we can fix the issue :)

Contributor

agross commented Jul 20, 2017

Or we can fix the issue :)

@forki forki closed this in e0034ca Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment