New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraining dependencies #2759

Closed
TheAngryByrd opened this Issue Sep 12, 2017 · 29 comments

Comments

Projects
None yet
4 participants
@TheAngryByrd
Contributor

TheAngryByrd commented Sep 12, 2017

Description

I have a project with <TargetFrameworks>netstandard1.6;net462</TargetFrameworks> If I use paket to do the restore I get

 Errors in /app/paket-constrain-framework.fsproj
      Package System.Security.Cryptography.OpenSsl 4.4.0 is not compatible with net462 (.NETFramework,Version=v4.6.2). Package System.Security.Cryptography.OpenSsl 4.4.0 supports:
        - netcoreapp2.0 (.NETCoreApp,Version=v2.0)
        - netstandard1.6 (.NETStandard,Version=v1.6)
        - netstandard2.0 (.NETStandard,Version=v2.0)
      One or more packages are incompatible with .NETFramework,Version=v4.6.2.

Repro steps

https://github.com/TheAngryByrd/paket-constrain-framework

Let me know if there's anything confusing or odd.

Expected behavior

Able to build

Actual behavior

Receive error message as shown above.

Known workarounds

Use nuget 😿

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

/cc @matthid

we have:

System.Security.Cryptography.OpenSsl (4.4) - restriction: || (&& (>= dnxcore50) (>= netstandard1.6)) (&& (>= netstandard1.6) (< monotouch) (< xamarintvos) (< xamarinwatchos) (< xamarinios) (< xamarinmac))

isn't net462 supposed to be compatible to netstandard1.6?

Member

forki commented Sep 13, 2017

/cc @matthid

we have:

System.Security.Cryptography.OpenSsl (4.4) - restriction: || (&& (>= dnxcore50) (>= netstandard1.6)) (&& (>= netstandard1.6) (< monotouch) (< xamarintvos) (< xamarinwatchos) (< xamarinios) (< xamarinmac))

isn't net462 supposed to be compatible to netstandard1.6?

@0x53A

This comment has been minimized.

Show comment
Hide comment
@0x53A

0x53A Sep 13, 2017

Contributor

Not yet. We are still at Tooling Level 1, so only netstandard1.5

image

Contributor

0x53A commented Sep 13, 2017

Not yet. We are still at Tooling Level 1, so only netstandard1.5

image

@TheAngryByrd

This comment has been minimized.

Show comment
Hide comment
@TheAngryByrd

TheAngryByrd Sep 13, 2017

Contributor

I guess the problem I see is it's choosing the netstandard FSharp.Core package over the netfull for net462.

Contributor

TheAngryByrd commented Sep 13, 2017

I guess the problem I see is it's choosing the netstandard FSharp.Core package over the netfull for net462.

@TheAngryByrd

This comment has been minimized.

Show comment
Hide comment
@TheAngryByrd

TheAngryByrd Sep 13, 2017

Contributor

Maybe it's because it's labeled as All Frameworks for 4.1.17 ?

Contributor

TheAngryByrd commented Sep 13, 2017

Maybe it's because it's labeled as All Frameworks for 4.1.17 ?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

why are you pinning to 4.1.7?

Member

forki commented Sep 13, 2017

why are you pinning to 4.1.7?

@TheAngryByrd

This comment has been minimized.

Show comment
Hide comment
@TheAngryByrd

TheAngryByrd Sep 13, 2017

Contributor

Just to be clear it's 4.1.17

.If you're a library author aren't you supposed to choose the lowest version you can? Or is that advice wrong now?

Contributor

TheAngryByrd commented Sep 13, 2017

Just to be clear it's 4.1.17

.If you're a library author aren't you supposed to choose the lowest version you can? Or is that advice wrong now?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

the problem ist that version doesn't work with netcore/netstandard

Member

forki commented Sep 13, 2017

the problem ist that version doesn't work with netcore/netstandard

@TheAngryByrd

This comment has been minimized.

Show comment
Hide comment
@TheAngryByrd

TheAngryByrd Sep 13, 2017

Contributor

The dependencies says netstandard1.6 and all frameworks. Is that wrong? Should that be unlisted then?

Contributor

TheAngryByrd commented Sep 13, 2017

The dependencies says netstandard1.6 and all frameworks. Is that wrong? Should that be unlisted then?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

no idea tbh

Member

forki commented Sep 13, 2017

no idea tbh

@TheAngryByrd

This comment has been minimized.

Show comment
Hide comment
@TheAngryByrd

TheAngryByrd Sep 13, 2017

Contributor

Doesn't really matter, FSharp.Core 4.2.3 produces the same problem.

Contributor

TheAngryByrd commented Sep 13, 2017

Doesn't really matter, FSharp.Core 4.2.3 produces the same problem.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

yes I think the FSHarp.Core is unrelated. What I wonder is why we have the following:

image

@matthid shouldn't this be filtered out?

Member

forki commented Sep 13, 2017

yes I think the FSHarp.Core is unrelated. What I wonder is why we have the following:

image

@matthid shouldn't this be filtered out?

@TheAngryByrd

This comment has been minimized.

Show comment
Hide comment
@TheAngryByrd

TheAngryByrd Sep 13, 2017

Contributor

Paket 5.91.0 does not have the issue, seems to start with 5.92.1.

Contributor

TheAngryByrd commented Sep 13, 2017

Paket 5.91.0 does not have the issue, seems to start with 5.92.1.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

yes that was when @matthid splitted the files. I assume it's related

Member

forki commented Sep 13, 2017

yes that was when @matthid splitted the files. I assume it's related

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 13, 2017

Member

what does paket why openssl say? (maybe we want an option to track only a particular framework in the future)

shouldn't this be filtered out

yes maybe

seems to start with 5.92.1

not sure why. I splitted the files but the observable behavior of nuget shouldn't have changed (I mean we basically should forward the same info)

Member

matthid commented Sep 13, 2017

what does paket why openssl say? (maybe we want an option to track only a particular framework in the future)

shouldn't this be filtered out

yes maybe

seems to start with 5.92.1

not sure why. I splitted the files but the observable behavior of nuget shouldn't have changed (I mean we basically should forward the same info)

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

should ;-)

Member

forki commented Sep 13, 2017

should ;-)

@forki

This comment has been minimized.

Show comment
Hide comment
@forki
Member

forki commented Sep 13, 2017

image

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 13, 2017

Member

Yes that path shouldn't exist after restricting to net462 ..

Member

matthid commented Sep 13, 2017

Yes that path shouldn't exist after restricting to net462 ..

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

just took a quick look. looks like the new files are not filterd by the targetframework filter

Member

forki commented Sep 13, 2017

just took a quick look. looks like the new files are not filterd by the targetframework filter

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 13, 2017

Member
  • maybe one of the framework restriction simplifications is invalid
  • or the framework restrictions of the nuget packages are not read in correctly
  • something in delegating the restrictions in the resolver itself.
Member

matthid commented Sep 13, 2017

  • maybe one of the framework restriction simplifications is invalid
  • or the framework restrictions of the nuget packages are not read in correctly
  • something in delegating the restrictions in the resolver itself.
@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 13, 2017

Member

or yes the files are written incorrectly

Member

matthid commented Sep 13, 2017

or yes the files are written incorrectly

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

the are all the same ;-)

Member

forki commented Sep 13, 2017

the are all the same ;-)

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 13, 2017

Member

but tbh the restriction in the lockfile looks aready fishy

Member

matthid commented Sep 13, 2017

but tbh the restriction in the lockfile looks aready fishy

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

that is another issue. the current issue is that we generate a files without filtering at all.

Member

forki commented Sep 13, 2017

that is another issue. the current issue is that we generate a files without filtering at all.

@forki forki closed this in 5f6bd1d Sep 13, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

small correction. it was filtering, but since we didn't clear the list that was not really effective. Anyway new version is under way and should be available in a minute

Member

forki commented Sep 13, 2017

small correction. it was filtering, but since we didn't clear the list that was not really effective. Anyway new version is under way and should be available in a minute

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

ok 5.96.1 is available

Member

forki commented Sep 13, 2017

ok 5.96.1 is available

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

and dotnet restore seems to work for your sample

Member

forki commented Sep 13, 2017

and dotnet restore seems to work for your sample

@forki forki added the bug label Sep 13, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Sep 13, 2017

Member

you might need to clean obj and paket-files folders

Member

forki commented Sep 13, 2017

you might need to clean obj and paket-files folders

@TheAngryByrd

This comment has been minimized.

Show comment
Hide comment
@TheAngryByrd

TheAngryByrd Sep 13, 2017

Contributor

🎸 you two rock

Contributor

TheAngryByrd commented Sep 13, 2017

🎸 you two rock

@matthid

This comment has been minimized.

Show comment
Hide comment
@matthid

matthid Sep 13, 2017

Member

@haf I remeber you encountered probably the same error but cannot find the issue/pr. please try again

Member

matthid commented Sep 13, 2017

@haf I remeber you encountered probably the same error but cannot find the issue/pr. please try again

@matthid matthid referenced this issue Sep 22, 2017

Closed

Ported everything to .NET Standard 1.6. #197

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment