New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding redirect should not use clitool dependencies #2955

Open
ctaggart opened this Issue Jan 1, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@ctaggart
Copy link
Contributor

ctaggart commented Jan 1, 2018

See fsprojects/Argu#99. tests/Argu.Core.Tests/App.config is being populated with dependencies from dotnet-sourcelink. That should not happen.

Paket version 5.128.0

@forki forki changed the title binding redirect should use clitool dependencies binding redirect should not use clitool dependencies Jan 3, 2018

forki added a commit that referenced this issue Jan 3, 2018

@forki forki closed this in #2959 Jan 3, 2018

@forki

This comment has been minimized.

Copy link
Member

forki commented Jan 3, 2018

@ctaggart can you please retry?

@ctaggart

This comment has been minimized.

Copy link
Contributor

ctaggart commented Jan 3, 2018

@forki, I keep getting:

C:\Users\camer\fs\Argu [sourcelink.test ≡ +0 ~1 -0 !]> .\.paket\paket.exe update --clean-redirects
Paket version 5.128.6
...
Paket failed with
-> Package directory for package Microsoft.CSharp was not found.

I deleted the folder from a couple of caches, but still same issue.

@forki

This comment has been minimized.

Copy link
Member

forki commented Jan 3, 2018

ok I can repro. Looking into it

@forki

This comment has been minimized.

Copy link
Member

forki commented Jan 3, 2018

fixed.

@ctaggart

This comment has been minimized.

Copy link
Contributor

ctaggart commented Jan 3, 2018

I no longer get the error about Microsoft.CSharp was not found. However, this issue about app.config containing redirect for the clitool is not yet fixed with paket 5.129.0.

Microsoft.Extensions.CommandLineUtils should not be in the app.config.
image

@forki

This comment has been minimized.

Copy link
Member

forki commented Jan 3, 2018

Mhm something still fucky. Sorry. Will investigate tomorrow

@forki forki reopened this Jan 3, 2018

@forki

This comment has been minimized.

Copy link
Member

forki commented Jan 4, 2018

oh it's not directly a clitool. It's just a dependency of a clitool that is not used somewhere else.
That's tricky ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment