New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket convert-from-nuget crash on nuget syntax #3151

Closed
tebeco opened this Issue Apr 12, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@tebeco

tebeco commented Apr 12, 2018

Description

paket does not read nuget constraints before parsing SemVer

Repro steps

  1. Create a project
  2. Add a package
  <ItemGroup>
    <PackageReference Include="MyPackage" Version="[1.0.0]" />
  </ItemGroup>
  1. Run dotnet restore
  2. It works
  3. paket convert-form-nuget --force
    bang

Paket failed with
-> Can't parse "[1.0.0]". System.ArgumentException: SemVer.Parse

Expected behavior

Read nuget constraints syntax

Actual behavior

Crash on convert

Known workarounds

None


image

@forki forki closed this in 833b36c Apr 13, 2018

@tebeco

This comment has been minimized.

tebeco commented Apr 13, 2018

Awesome thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment