Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket restore doesn't download http dependencies #536

Closed
tpluscode opened this issue Jan 9, 2015 · 11 comments
Closed

Paket restore doesn't download http dependencies #536

tpluscode opened this issue Jan 9, 2015 · 11 comments
Labels
bug

Comments

@tpluscode
Copy link
Contributor

@tpluscode tpluscode commented Jan 9, 2015

As per the title please try doing paket restore in repository https://github.com/wikibus/JsonLD.Entities. The one http dependency will not be downloaded. It's defined as follows

http http://www.w3.org/2013/N-QuadsTests TESTS.zip
@forki

This comment has been minimized.

Copy link
Member

@forki forki commented Jan 9, 2015

image

@forki

This comment has been minimized.

Copy link
Member

@forki forki commented Jan 9, 2015

can't reproduce. works as expected

@tpluscode

This comment has been minimized.

Copy link
Contributor Author

@tpluscode tpluscode commented Jan 9, 2015

You're showing me github files. There should be two folders in paket-files

@forki

This comment has been minimized.

Copy link
Member

@forki forki commented Jan 9, 2015

ah I see

@forki

This comment has been minimized.

Copy link
Member

@forki forki commented Jan 9, 2015

after changing the link (see #537) and running update we get a change in the lockfile:

image

I can now confirm: restore fails to parse this.

@forki forki added the bug label Jan 9, 2015
@forki forki closed this in 44e954e Jan 9, 2015
forki added a commit that referenced this issue Jan 9, 2015
fix parsing of longer http links - fixes #536
@tpluscode

This comment has been minimized.

Copy link
Contributor Author

@tpluscode tpluscode commented Jan 9, 2015

Thank you for acting so quickly again 👍

So is full URI the correct syntax for http dependency?

@forki

This comment has been minimized.

Copy link
Member

@forki forki commented Jan 9, 2015

yep. it would be awesome if you could try to reread the docs and improve it if it is wrong or misleading.

@tpluscode

This comment has been minimized.

Copy link
Contributor Author

@tpluscode tpluscode commented Jan 9, 2015

sure thing. will do first thing tomorrow. maybe after breakfast ;)

@tpluscode

This comment has been minimized.

Copy link
Contributor Author

@tpluscode tpluscode commented Jan 10, 2015

Hm, I wanted to create a pull request for gh-pages but I see that you keep entire HTML documents. Are they generated from somewhere with Jekyll or whatever?

@theimowski

This comment has been minimized.

Copy link
Member

@theimowski theimowski commented Jan 10, 2015

We use FSharp.Formatting to generate the docs. Just edit one of the markdown files: https://github.com/fsprojects/Paket/blob/master/docs/content/http-dependencies.md and run build GenerateHelp - it should generate the htmls to /docs/output

@forki

This comment has been minimized.

Copy link
Member

@forki forki commented Jan 10, 2015

There is also
https://github.com/fsprojects/Paket/blob/master/src/Paket/HelpTexts.fs -
this file contains the sources of the command texts
On Jan 10, 2015 8:50 AM, "Tomasz Heimowski" notifications@github.com
wrote:

We use FSharp.Formatting https://github.com/tpetricek/FSharp.Formatting
to generate the docs. Just edit one of the markdown files:
https://github.com/fsprojects/Paket/blob/master/docs/content/http-dependencies.md
and run build GenerateHelp - it should generate the htmls to /docs/output


Reply to this email directly or view it on GitHub
#536 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.