Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make option names for paket find-package-versions consistent with the other packages #890

Closed
cr7pt0gr4ph7 opened this issue Jun 21, 2015 · 7 comments

Comments

@cr7pt0gr4ph7
Copy link
Contributor

Currently, the names of the options for paket find-package-versions are inconsistent with the other commands:

paket find-package-versions name My.Package

Compare with:

paket add nuget My.Package
paket remove nuget My.Package
paket update nuget My.Package
paket find-refs nuget My.Package Other.Package

The proposal would be to rename the name <string> argument to nuget <string>.

@ctaggart
Copy link
Contributor

👍

@forki
Copy link
Member

forki commented Jun 23, 2015

If we want to do this, then we need to patch dependent tools (I assume only atom).
//cc @Krzysztof-Cieslak

@ctaggart
Copy link
Contributor

And powershell arg completion.

@cr7pt0gr4ph7
Copy link
Contributor Author

I assume that changing the argument name is a breaking change, which would require a new major version number; especially given that find-package-versions is likely used in command line completion scripts. But one could also say that its marked as "EXPERIMENTAL", so that such changes are okay.

What about adding the nuget argument, but keeping the old name argument, adding a [<ArgUnionParser.Hidden>] attribute to it and displaying a deprecation warning if its used (except if --silent is given)? The plan would be to remove it in a later version.

@Krzysztof-Cieslak
Copy link
Member

It's one line of code change in Atom plugin. Don't see any problem from this point of view.

@forki forki closed this as completed in 61dc5fa Aug 13, 2015
@forki
Copy link
Member

forki commented Aug 13, 2015

@Krzysztof-Cieslak done in 1.27.2. please let me know when you updated atom. we will then remove the name completely.

@Krzysztof-Cieslak
Copy link
Member

@forki, Atom plugin updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants