Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude directories from processing #918

Closed
ghost opened this issue Jul 8, 2015 · 4 comments
Closed

Exclude directories from processing #918

ghost opened this issue Jul 8, 2015 · 4 comments
Labels
bug

Comments

@ghost
Copy link

@ghost ghost commented Jul 8, 2015

Hello,

What:
It would be nice if I could tell Paket to ignore specific directories from processing (paket install).

Why:
We added git submodules to our repository and some (sub) projects use Paket as well. During paket install it detects ALL paket.reference files and replaces the DLL reference paths accordingly.

Example:

     <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.0')">
       <ItemGroup>
         <Reference Include="System.Reactive.Core">
-          <HintPath>..\..\..\..\packages\Rx-Core\lib\net40\System.Reactive.Core.dll</HintPath>
+          <HintPath>..\..\..\..\..\..\packages\Rx-Core\lib\net40\System.Reactive.Core.dll</HintPath>^M
           <Private>True</Private>
           <Paket>True</Paket>
         </Reference>

The sub modules should not use the root/packages directory. The directory root/submodule path/packages makes much more sense. The root/paket.dependencies and root/paket.lock shouldn't apply sub modules dependencies.

Proposal:

a.)
Add a paket.ignore file that contains directory names to ignore.

+ <root>
|-+ submodules
  |-- paket.ignore
  |-+ submodule-1
    |-- .git
  |-+ submodule-2
    |-- .git

File content of paket.ignore (maybe regex?):

submodule-1
submodule-1

b.)
Paket recognises the sub directory's paket.lock + paket.dependencies files and processes the sub folder independently.

Greetings,
Daniel

@agross

This comment has been minimized.

Copy link
Contributor

@agross agross commented Jul 8, 2015

Ad a): An empty file would be OK as well to exclude everything below the directory paket.ignore is in.

@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Jul 8, 2015

@agross: if the paket.ignore file supports regular expressions as pattern, you could just add .* as file content.

@forki

This comment has been minimized.

Copy link
Member

@forki forki commented Jul 19, 2015

I like the idea of just stopping if we find another paket.dependencies file. This will help here and avoids lots of confusion.

@forki forki added the bug label Jul 19, 2015
@forki forki closed this in 6283f76 Jul 19, 2015
@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Jul 20, 2015

Cool! Thanks!

haraldsteinlechner added a commit to haraldsteinlechner/Paket that referenced this issue Apr 12, 2016
…tedDefinitions which results in exceptions during pack, due to a bug in FSharp.Data fsprojects#918)
haraldsteinlechner added a commit to haraldsteinlechner/Paket that referenced this issue Apr 12, 2016
…tedDefinitions which results in exceptions during pack, due to a bug in FSharp.Data fsprojects#918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.