New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore disabled upstream feeds #1105

Merged
merged 2 commits into from Oct 3, 2015

Conversation

Projects
None yet
2 participants
@theimowski
Member

theimowski commented Oct 3, 2015

No description provided.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 3, 2015

Member

any ideas why the mono build fails on the sample?

Member

forki commented Oct 3, 2015

any ideas why the mono build fails on the sample?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 3, 2015

Member

I guess it was 6cce933#diff-86117e2b5523a68369ab3089fdcff773R79

thanks for contributing!

Member

forki commented Oct 3, 2015

I guess it was 6cce933#diff-86117e2b5523a68369ab3089fdcff773R79

thanks for contributing!

@forki forki merged commit 7d63416 into fsprojects:master Oct 3, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Oct 3, 2015

Member

ah didn't know Mono doesn't like these - do you know exact reason why that happens?

Member

theimowski commented Oct 3, 2015

ah didn't know Mono doesn't like these - do you know exact reason why that happens?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 3, 2015

Member

Yes. Filename is case-sensitive. You named the folder "NuGet..." but wrote
"Nuget..." in test. It just didn't find the file...
On Oct 3, 2015 12:55, "Tomasz Heimowski" notifications@github.com wrote:

ah didn't know Mono doesn't like these - do you know exact reason why that
happens?


Reply to this email directly or view it on GitHub
#1105 (comment).

Member

forki commented Oct 3, 2015

Yes. Filename is case-sensitive. You named the folder "NuGet..." but wrote
"Nuget..." in test. It just didn't find the file...
On Oct 3, 2015 12:55, "Tomasz Heimowski" notifications@github.com wrote:

ah didn't know Mono doesn't like these - do you know exact reason why that
happens?


Reply to this email directly or view it on GitHub
#1105 (comment).

@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Oct 3, 2015

Member

ok I understand know - didn't notice case sensitive file names.
You also changed preservenewset to copyalways - is there any reason for that why mono would fail otherwise?

Member

theimowski commented Oct 3, 2015

ok I understand know - didn't notice case sensitive file names.
You also changed preservenewset to copyalways - is there any reason for that why mono would fail otherwise?

@theimowski theimowski deleted the theimowski:ignore_disabled_upstream_feeds branch Oct 3, 2015

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 3, 2015

Member

The copyalways was only my first thought. But it wasn't the reason.
Everything was ok, only the file was not good on nix
On Oct 3, 2015 12:59, "Tomasz Heimowski" notifications@github.com wrote:

ok I understand know - didn't notice case sensitive file names.
you also changed preservenewset to copyalways - is there any reason for
that why mono would fail otherwise?


Reply to this email directly or view it on GitHub
#1105 (comment).

Member

forki commented Oct 3, 2015

The copyalways was only my first thought. But it wasn't the reason.
Everything was ok, only the file was not good on nix
On Oct 3, 2015 12:59, "Tomasz Heimowski" notifications@github.com wrote:

ok I understand know - didn't notice case sensitive file names.
you also changed preservenewset to copyalways - is there any reason for
that why mono would fail otherwise?


Reply to this email directly or view it on GitHub
#1105 (comment).

@theimowski

This comment has been minimized.

Show comment
Hide comment
@theimowski

theimowski Oct 3, 2015

Member

I see, glad I could be of help!

Member

theimowski commented Oct 3, 2015

I see, glad I could be of help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment