New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle silverlight framework identifiers comparison #1138

Merged
merged 3 commits into from Oct 15, 2015

Conversation

Projects
None yet
2 participants
@vbfox
Contributor

vbfox commented Oct 15, 2015

Continue on & rebase #1130 (That was itself based on #1127)

I didn't keep the history because the back & forth was just making the pull request unreadable.

FrameworkRestriction.IsSameCategoryAs was introduced in addition to the version on FrameworkIdentifier to avoid repeating the checks over and over.

vbfox added some commits Oct 11, 2015

Handle framework identifiers comparison
FrameworkIdentifier instances were compared structurally before but it
was problematic in some cases as '>= net45' matched 'sl40' that wasn't
in the same framework.

Fixes #1124
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 15, 2015

Member

so is this already ready?

Member

forki commented Oct 15, 2015

so is this already ready?

@vbfox

This comment has been minimized.

Show comment
Hide comment
@vbfox

vbfox Oct 15, 2015

Contributor

Yes I think it is, I ran paket install on our work solution and between this change and #1137 it really clean the references & Conditions in the projects.

Actually #1137 even found a bug in our restrictions where a >= net451 package was used in a net40 project 👍

Contributor

vbfox commented Oct 15, 2015

Yes I think it is, I ran paket install on our work solution and between this change and #1137 it really clean the references & Conditions in the projects.

Actually #1137 even found a bug in our restrictions where a >= net451 package was used in a net40 project 👍

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Oct 15, 2015

Member

very cool

Member

forki commented Oct 15, 2015

very cool

forki added a commit that referenced this pull request Oct 15, 2015

Merge pull request #1138 from vbfox/silverlight-dotnet-framework2
Handle silverlight framework identifiers comparison

@forki forki merged commit 4f79f6c into fsprojects:master Oct 15, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment