New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes lock file restrictions parsing #1144

Merged
merged 1 commit into from Oct 17, 2015

Conversation

Projects
None yet
2 participants
@mrinaldi
Contributor

mrinaldi commented Oct 16, 2015

This PR fixes the parsing of restrictions of transitive dependencies in lock file.

Using the paket.dependencies below

source https://nuget.org/api/v2

nuget Microsoft.Owin.Host.SystemWeb ~> 2.1

It generates a different paket.lock when I run paket install twice.
The same happens if I run a paket update followed by a paket install.

let optionsString =
if parts.Length < 2 then "" else
if parts.[1] <> "" && parts.[1].Contains(":") |> not then
("framework: " + parts.[1]) // TODO: This is for backwards-compat and should be removed later

This comment has been minimized.

@mrinaldi

mrinaldi Oct 16, 2015

Contributor

Should this be removed by now?

@mrinaldi

mrinaldi Oct 16, 2015

Contributor

Should this be removed by now?

This comment has been minimized.

@forki

forki Oct 17, 2015

Member

Nope. Please remove the comment. I guess we better keep it forever

@forki

forki Oct 17, 2015

Member

Nope. Please remove the comment. I guess we better keep it forever

@forki forki merged commit a2977e1 into fsprojects:master Oct 17, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrinaldi mrinaldi deleted the mrinaldi:parse_lockfile_restrictions branch Oct 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment