Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to cache proxy #1153

Merged
merged 11 commits into from Oct 21, 2015
Merged

try to cache proxy #1153

merged 11 commits into from Oct 21, 2015

Conversation

@forki
Copy link
Member

forki commented Oct 19, 2015

for a couple of users it seems to be very very slow to calc the proxy. see https://gitter.im/fsprojects/Paket discussion with @alexeyzimarev

@forki

This comment has been minimized.

Copy link
Member Author

forki commented Oct 19, 2015

//cc @vasily-kirichenko could you please take a look?

@vasily-kirichenko

This comment has been minimized.

Copy link
Contributor

vasily-kirichenko commented Oct 19, 2015

Looks like an ordinary thread safe memoization. Maybe it is worth to extract memoze into some core module.

@forki

This comment has been minimized.

Copy link
Member Author

forki commented Oct 19, 2015

the question is more: do you think it's enough to cache proxy per HTTP host?

@vasily-kirichenko

This comment has been minimized.

Copy link
Contributor

vasily-kirichenko commented Oct 19, 2015

No idea.

@forki

This comment has been minimized.

Copy link
Member Author

forki commented Oct 19, 2015

fair enough ;-)

@forki

This comment has been minimized.

Copy link
Member Author

forki commented Oct 19, 2015

I released this as 2.16.0-alpha001.
ypu can get it with paket.bootstrapper.exe prerelease

@alexeyzimarev, @alistair please check if it improves things

@vasily-kirichenko could you please verify that we don't break you

thanks everbody.

@forki

This comment has been minimized.

Copy link
Member Author

forki commented Oct 19, 2015

@dnauck you are also behind proxy, right?

@alexeyzimarev

This comment has been minimized.

Copy link

alexeyzimarev commented Oct 19, 2015

I am at home now and have no proxy. Will be able to check tomorrow if I would reach my machine at work, I will be at another office for three days.

@alistair

This comment has been minimized.

Copy link

alistair commented Oct 19, 2015

So I have just updated to the latest, cleaned cache and packages directory and run the following

https://gist.github.com/alistair/65cba5d92556e6f0457c

Time taken has dropped from 7 minutes to 1.

@dnauck

This comment has been minimized.

Copy link
Contributor

dnauck commented Oct 19, 2015

@forki no .. not with my dev machine, cannot test

Most commercial proxy solutions have virus checking, so the first download and unzip of nuget packages for virus check could take a long time. If the package is too large or contains to many files it could also fail.

@forki forki force-pushed the proxy branch from a99c09b to 7149763 Oct 20, 2015
forki added 8 commits Oct 20, 2015
Conflicts:
	RELEASE_NOTES.md
	src/Paket.Bootstrapper/Properties/AssemblyInfo.cs
	src/Paket.Core/AssemblyInfo.fs
	src/Paket.PowerShell/AssemblyInfo.fs
	src/Paket/AssemblyInfo.fs
Conflicts:
	RELEASE_NOTES.md
	src/Paket.Bootstrapper/Properties/AssemblyInfo.cs
	src/Paket.Core/AssemblyInfo.fs
	src/Paket.PowerShell/AssemblyInfo.fs
	src/Paket/AssemblyInfo.fs
Conflicts:
	RELEASE_NOTES.md
	src/Paket.Bootstrapper/Properties/AssemblyInfo.cs
	src/Paket.Core/AssemblyInfo.fs
	src/Paket.PowerShell/AssemblyInfo.fs
	src/Paket/AssemblyInfo.fs
@forki forki merged commit 7c6748d into master Oct 21, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@alexeyzimarev

This comment has been minimized.

Copy link

alexeyzimarev commented Oct 23, 2015

I tested with 2.16.0 and it works splendidly 👍 46 seconds instead of seven minutes.

@forki

This comment has been minimized.

Copy link
Member Author

forki commented Oct 23, 2015

Awesome. Thanks for all the help here.

@vasily-kirichenko

This comment has been minimized.

Copy link
Contributor

vasily-kirichenko commented Oct 23, 2015

Tested paket outdated on 2.16.0. Works OK, but I'm not sure it's faster.

@forki

This comment has been minimized.

Copy link
Member Author

forki commented Oct 23, 2015

It's only faster for a handful of people where the proxy detection was
super slow. Most people (like myself) will not have perf gains. But I was
worried that caching might break things.
On Oct 23, 2015 8:55 AM, "Vasily Kirichenko" notifications@github.com
wrote:

Tested paket outdated on 2.16.0. Works OK, but I'm not sure it's faster.


Reply to this email directly or view it on GitHub
#1153 (comment).

@matthid matthid deleted the proxy branch May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.