New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates and parses strategy option in lock file #1196

Merged
merged 2 commits into from Nov 5, 2015

Conversation

Projects
None yet
2 participants
@mrinaldi
Contributor

mrinaldi commented Nov 5, 2015

This PR generates and parses strategy option in lock file. The lack of it is causing the install process to detect changes when there is none.

Running paket install several times against this paket.dependencies:

source https://www.nuget.org/api/v2/
strategy: min

nuget Paket.Core

would not skip the resolver. Here is the output:

Paket version 2.22.0.0
Resolving packages for group Main:
 - Paket.Core 2.22.0
 - FSharp.Core 3.0.2
 - Newtonsoft.Json 3.5.8
D:\Projects\paket-test\paket.lock is already up-to-date
1 second - ready.

This is the output of this PR:

Paket version 2.22.0.0
Skipping resolver for group Main since it is already up-to-date
D:\Projects\paket-test\paket.lock is already up-to-date
0 seconds - ready.
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 5, 2015

Member

very good.

in the default case (Strategy max) we should not touch the lock file. is this the case?

Member

forki commented Nov 5, 2015

very good.

in the default case (Strategy max) we should not touch the lock file. is this the case?

@mrinaldi

This comment has been minimized.

Show comment
Hide comment
@mrinaldi

mrinaldi Nov 5, 2015

Contributor

The default case is actually no strategy at all, which internally will be treated as max.
Indeed, for that case, we don't touch the lock file.

If the strategy max is specified though, it'll touch the lock file, and I believe it should, since it's explicit specified.

Contributor

mrinaldi commented Nov 5, 2015

The default case is actually no strategy at all, which internally will be treated as max.
Indeed, for that case, we don't touch the lock file.

If the strategy max is specified though, it'll touch the lock file, and I believe it should, since it's explicit specified.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 5, 2015

Member

very good!

Member

forki commented Nov 5, 2015

very good!

forki added a commit that referenced this pull request Nov 5, 2015

Merge pull request #1196 from mrinaldi/lockfile_strategy_option
Generates and parses strategy option in lock file

@forki forki merged commit a6e4d67 into fsprojects:master Nov 5, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrinaldi mrinaldi deleted the mrinaldi:lockfile_strategy_option branch Nov 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment