New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ListTemplateFiles more robust #1209

Merged
merged 1 commit into from Nov 11, 2015

Conversation

Projects
None yet
2 participants
@krgn
Contributor

krgn commented Nov 10, 2015

A TemplateFile may not be loadable if some of the referenced files are not available (e.g. the Paket.PowerShell project and its dependencies on Linux) and thus renders the method useless in these scenarios.

I refined the loading process to skip TemplateFiles that crash on Load.

@krgn krgn changed the title from make ListTemplateFiles more rebust to make ListTemplateFiles more robust Nov 10, 2015

forki added a commit that referenced this pull request Nov 11, 2015

Merge pull request #1209 from krgn/prevent-crash-TemplateFile-load
make ListTemplateFiles more robust

@forki forki merged commit c4292bb into fsprojects:master Nov 11, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 11, 2015

Member

thx

Member

forki commented Nov 11, 2015

thx

@krgn krgn deleted the krgn:prevent-crash-TemplateFile-load branch Nov 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment