New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageSources: do not print feed password to output #1224 #1238

Merged
merged 1 commit into from Nov 19, 2015

Conversation

Projects
None yet
2 participants
@cdrnet
Member

cdrnet commented Nov 19, 2015

In NuGetV2.GetVersions use the same approach as in GetPackageDetails to just print the feed url instead of the full record including the password, to avoid leaking the password unnecessarily to the console output.

It is correct that the password is lying around (at least encrypted) in paket.config, but it's still awkward seeing your personal password floating by on the console when pair-programming ;)

See also #1224

forki added a commit that referenced this pull request Nov 19, 2015

Merge pull request #1238 from cdrnet/dont-leak-password
PackageSources: do not print feed password to output #1224

@forki forki merged commit 31ff126 into fsprojects:master Nov 19, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Nov 19, 2015

Member

thx

Member

forki commented Nov 19, 2015

thx

@cdrnet cdrnet deleted the cdrnet:dont-leak-password branch Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment