Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#784 warning when resolving unlisted package #1258

Merged
merged 1 commit into from Nov 27, 2015

Conversation

@alex-bogomaz
Copy link
Contributor

@alex-bogomaz alex-bogomaz commented Nov 25, 2015

hi. Please review this pull request. Now warning is displayed when unlisted package is resolved

@forki
Copy link
Member

@forki forki commented Nov 26, 2015

I think we should only warn when the resolver terminates with unlisted packages.

forki added a commit that referenced this pull request Nov 27, 2015
#784 warning when resolving unlisted package
@forki forki merged commit 2c7e7bc into fsprojects:master Nov 27, 2015
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@forki
Copy link
Member

@forki forki commented Nov 27, 2015

thx for submitting. I move the code a bit. see 88b8023 - does this work for you?

@alex-bogomaz
Copy link
Contributor Author

@alex-bogomaz alex-bogomaz commented Nov 30, 2015

sure, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.